* [PATCH] regulator: isl6271a: Remove setting map_voltage callback for isl_fixed_ops
@ 2012-06-08 2:04 Axel Lin
2012-06-11 3:41 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2012-06-08 2:04 UTC (permalink / raw)
To: linux-kernel; +Cc: Marek Vasut, Liam Girdwood, Mark Brown
isl_fixed_ops does not implement set_voltage_sel callback, adding map_voltage
here is misleading.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/regulator/isl6271a-regulator.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/regulator/isl6271a-regulator.c b/drivers/regulator/isl6271a-regulator.c
index 4a11b82..1d145a0 100644
--- a/drivers/regulator/isl6271a-regulator.c
+++ b/drivers/regulator/isl6271a-regulator.c
@@ -81,7 +81,6 @@ static int isl6271a_get_fixed_voltage(struct regulator_dev *dev)
static struct regulator_ops isl_fixed_ops = {
.get_voltage = isl6271a_get_fixed_voltage,
.list_voltage = regulator_list_voltage_linear,
- .map_voltage = regulator_map_voltage_linear,
};
static const struct regulator_desc isl_rd[] = {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] regulator: isl6271a: Remove setting map_voltage callback for isl_fixed_ops
2012-06-08 2:04 [PATCH] regulator: isl6271a: Remove setting map_voltage callback for isl_fixed_ops Axel Lin
@ 2012-06-11 3:41 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-06-11 3:41 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Marek Vasut, Liam Girdwood
[-- Attachment #1: Type: text/plain, Size: 178 bytes --]
On Fri, Jun 08, 2012 at 10:04:42AM +0800, Axel Lin wrote:
> isl_fixed_ops does not implement set_voltage_sel callback, adding map_voltage
> here is misleading.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-11 3:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-08 2:04 [PATCH] regulator: isl6271a: Remove setting map_voltage callback for isl_fixed_ops Axel Lin
2012-06-11 3:41 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox