* Re: [PATCH] firewire: core: add is_local sysfs device attribute
[not found] <4FDDEC64.5080004@ladisch.de>
@ 2012-06-17 17:56 ` Stefan Richter
2012-06-17 17:57 ` [PATCH] firewire: core: document is_local sysfs attribute Stefan Richter
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Richter @ 2012-06-17 17:56 UTC (permalink / raw)
To: Clemens Ladisch; +Cc: linux1394-devel, linux-kernel
On Jun 17 Clemens Ladisch wrote:
> Making this information available in sysfs allows to differentiate
> between controllers in the local and remote Linux PCs, and thus is
> useful for servers that are started with udev rules.
>
> Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
Looks good to me. Cc'ing LKML, and sending ABI documentation in a reply.
> ---
> drivers/firewire/core-device.c | 9 +++++++++
> include/linux/firewire.h | 2 +-
> 2 files changed, 10 insertions(+), 1 deletions(-)
>
> --- a/drivers/firewire/core-device.c
> +++ b/drivers/firewire/core-device.c
> @@ -398,6 +398,14 @@ static ssize_t guid_show(struct device *dev,
> return ret;
> }
>
> +static ssize_t is_local_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + struct fw_device *device = fw_device(dev);
> +
> + return sprintf(buf, "%u\n", device->is_local);
> +}
> +
> static int units_sprintf(char *buf, const u32 *directory)
> {
> struct fw_csr_iterator ci;
> @@ -447,6 +455,7 @@ static ssize_t units_show(struct device *dev,
> static struct device_attribute fw_device_attributes[] = {
> __ATTR_RO(config_rom),
> __ATTR_RO(guid),
> + __ATTR_RO(is_local),
> __ATTR_RO(units),
> __ATTR_NULL,
> };
> --- a/include/linux/firewire.h
> +++ b/include/linux/firewire.h
> @@ -152,7 +152,7 @@ static inline void fw_card_put(struct fw_card *card)
> struct fw_attribute_group {
> struct attribute_group *groups[2];
> struct attribute_group group;
> - struct attribute *attrs[12];
> + struct attribute *attrs[13];
> };
>
> enum fw_device_state {
--
Stefan Richter
-=====-===-- -==- =---=
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 2+ messages in thread