The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: platform-driver-x86@vger.kernel.org
Cc: Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux PM list <linux-pm@vger.kernel.org>,
	Matthew Garrett <mjg59@srcf.ucam.org>, Joey Lee <jlee@novell.com>,
	Jesse Barnes <jesse.barnes@intel.com>,
	Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: [PATCH 5/5] intel_ips: Remove empty legacy PM callbacks
Date: Sun, 17 Jun 2012 22:30:40 +0200	[thread overview]
Message-ID: <201206172230.40711.rjw@sisk.pl> (raw)
In-Reply-To: <201206172226.42729.rjw@sisk.pl>

From: Rafael J. Wysocki <rjw@sisk.pl>

The legacy PM callbacks provided by the Intel IPS driver are
empty routines returning 0, so they can be safely dropped.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 drivers/platform/x86/intel_ips.c |   17 -----------------
 1 file changed, 17 deletions(-)

Index: linux/drivers/platform/x86/intel_ips.c
===================================================================
--- linux.orig/drivers/platform/x86/intel_ips.c
+++ linux/drivers/platform/x86/intel_ips.c
@@ -1697,21 +1697,6 @@ static void ips_remove(struct pci_dev *d
 	dev_dbg(&dev->dev, "IPS driver removed\n");
 }
 
-#ifdef CONFIG_PM
-static int ips_suspend(struct pci_dev *dev, pm_message_t state)
-{
-	return 0;
-}
-
-static int ips_resume(struct pci_dev *dev)
-{
-	return 0;
-}
-#else
-#define ips_suspend NULL
-#define ips_resume NULL
-#endif /* CONFIG_PM */
-
 static void ips_shutdown(struct pci_dev *dev)
 {
 }
@@ -1721,8 +1706,6 @@ static struct pci_driver ips_pci_driver
 	.id_table = ips_id_table,
 	.probe = ips_probe,
 	.remove = ips_remove,
-	.suspend = ips_suspend,
-	.resume = ips_resume,
 	.shutdown = ips_shutdown,
 };
 


      parent reply	other threads:[~2012-06-17 20:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-17 20:26 [PATCH 0/5] platform / x86: Convert a few drivers to struct dev_pm_ops Rafael J. Wysocki
2012-06-17 20:27 ` [PATCH 1/5] thinkpad_acpi: Drop pm_message_t arguments from suspend routines Rafael J. Wysocki
2012-06-24  0:32   ` Henrique de Moraes Holschuh
2012-06-17 20:27 ` [PATCH 2/5] thinkpad_acpi: Use struct dev_pm_ops instead of legacy PM routines Rafael J. Wysocki
2012-06-24  0:34   ` Henrique de Moraes Holschuh
2012-06-24 20:01     ` Rafael J. Wysocki
2012-06-17 20:28 ` [PATCH 3/5] acer-wmi: Use struct dev_pm_ops for power management Rafael J. Wysocki
2012-06-18  6:56   ` joeyli
2012-06-17 20:29 ` [PATCH 4/5] intel_mid_thermal: " Rafael J. Wysocki
2012-06-18  6:03   ` R, Durgadoss
2012-06-17 20:30 ` Rafael J. Wysocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201206172230.40711.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=ibm-acpi@hmh.eng.br \
    --cc=jbarnes@virtuousgeek.org \
    --cc=jesse.barnes@intel.com \
    --cc=jlee@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox