* [PATCH 3/3] regulator: change message level on probing lp872x driver
@ 2012-06-21 8:03 Kim, Milo
2012-06-21 9:24 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Kim, Milo @ 2012-06-21 8:03 UTC (permalink / raw)
To: Mark Brown
Cc: Girdwood, Liam, linux-kernel@vger.kernel.org, axel.lin@gmail.com,
swarren@wwwdotorg.org, sfr@canb.auug.org.au
Use err log rather than warning message when the platform data is NULL
Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
---
drivers/regulator/lp872x.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/regulator/lp872x.c b/drivers/regulator/lp872x.c
index daaa0ed..0c0e62f 100644
--- a/drivers/regulator/lp872x.c
+++ b/drivers/regulator/lp872x.c
@@ -891,7 +891,7 @@ static int lp872x_probe(struct i2c_client *cl, const struct i2c_device_id *id)
};
if (!pdata) {
- dev_warn(&cl->dev, "no platform data\n");
+ dev_err(&cl->dev, "no platform data\n");
return -EINVAL;
}
--
1.7.2.5
Best Regards,
Milo (Woogyom) Kim
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 3/3] regulator: change message level on probing lp872x driver
2012-06-21 8:03 [PATCH 3/3] regulator: change message level on probing lp872x driver Kim, Milo
@ 2012-06-21 9:24 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-06-21 9:24 UTC (permalink / raw)
To: Kim, Milo
Cc: Girdwood, Liam, linux-kernel@vger.kernel.org, axel.lin@gmail.com,
swarren@wwwdotorg.org, sfr@canb.auug.org.au
[-- Attachment #1: Type: text/plain, Size: 267 bytes --]
On Thu, Jun 21, 2012 at 08:03:56AM +0000, Kim, Milo wrote:
> Use err log rather than warning message when the platform data is NULL
Really what you should be doing here is making the driver able to probe
without platform data at all, there should be no need for it.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-21 9:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-21 8:03 [PATCH 3/3] regulator: change message level on probing lp872x driver Kim, Milo
2012-06-21 9:24 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox