From: Pablo Neira Ayuso <pablo@netfilter.org>
To: valdis.kletnieks@vt.edu
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: next-20120620 build error in netfilter
Date: Sat, 23 Jun 2012 02:20:35 +0200 [thread overview]
Message-ID: <20120623002035.GB21360@1984> (raw)
In-Reply-To: <55558.1340217472@turing-police.cc.vt.edu>
On Wed, Jun 20, 2012 at 02:37:52PM -0400, valdis.kletnieks@vt.edu wrote:
> On Wed, 20 Jun 2012 19:28:01 +0200, Pablo Neira Ayuso said:
> > On Wed, Jun 20, 2012 at 01:14:33PM -0400, Valdis Kletnieks wrote:
> > > Today's linux-next fails to build with CONFIG_NF_NAT_NEEDED=y and CONFIG_NF_NAT=m
> > >
> > > LD init/built-in.o
> > > net/built-in.o:(.data+0x4408): undefined reference to `nf_nat_tcp_seq_adjust'
> > > make: *** [vmlinux] Error 1
> >
> > I guess you have NF_CT_NETLINK=y, right?
>
> Yes.
>
> Temporary workaround was setting NF_NAT=n (I don't use NAT, I just usually
> build all the netfilter modules as =m even if I don't use them, just to provide
> build coverage and trip over stuff like this).
Probably NF_CT_NETLINK=m is a better workaround.
Anyway, I've enqueued the following patch to fix this:
http://1984.lsi.us.es/git/nf-next/commit/?id=d584a61a931e6cbfef0dd811c4ae0250ec5987f4
So you can use your previous config.
Thanks.
prev parent reply other threads:[~2012-06-23 0:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 17:14 next-20120620 build error in netfilter Valdis Kletnieks
2012-06-20 17:28 ` Pablo Neira Ayuso
2012-06-20 18:37 ` valdis.kletnieks
2012-06-23 0:20 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120623002035.GB21360@1984 \
--to=pablo@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox