[PATCH] sound: fix MODULE_LICENSE typos

[PATCH] sound: fix MODULE_LICENSE typos

[Kees Cook]

include/linux/license.h does not recognize "GPLv2", so adjust these
declarations to add the needed space before the version.

Signed-off-by: Kees Cook <keescook@chromium.org>
---
 sound/soc/ux500/ux500_msp_dai.c |    2 +-
 sound/soc/ux500/ux500_msp_i2s.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/ux500/ux500_msp_dai.c b/sound/soc/ux500/ux500_msp_dai.c
index 93c6c40..62ac028 100644
--- a/sound/soc/ux500/ux500_msp_dai.c
+++ b/sound/soc/ux500/ux500_msp_dai.c
@@ -840,4 +840,4 @@ static struct platform_driver msp_i2s_driver = {
 };
 module_platform_driver(msp_i2s_driver);
 
-MODULE_LICENSE("GPLv2");
+MODULE_LICENSE("GPL v2");
diff --git a/sound/soc/ux500/ux500_msp_i2s.c b/sound/soc/ux500/ux500_msp_i2s.c
index 496dec1..ee14d2d 100644
--- a/sound/soc/ux500/ux500_msp_i2s.c
+++ b/sound/soc/ux500/ux500_msp_i2s.c
@@ -739,4 +739,4 @@ void ux500_msp_i2s_cleanup_msp(struct platform_device *pdev,
 	devm_kfree(&pdev->dev, msp);
 }
 
-MODULE_LICENSE("GPLv2");
+MODULE_LICENSE("GPL v2");
-- 
1.7.0.4

Re: [PATCH] sound: fix MODULE_LICENSE typos

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 608 bytes --]

On Fri, Jun 22, 2012 at 04:21:49PM -0700, Kees Cook wrote:
> include/linux/license.h does not recognize "GPLv2", so adjust these
> declarations to add the needed space before the version.

This patch isn't against current -next which doesn't have this issue,
I've no idea what you generated against as a version with this has never
even been in -next.  Please do also use subject lines that resemble
those used in the rest of the subsystem, having to hand edit commit logs
is tedious.

It seems more sensible to fix license.h, GPLv2 is a pretty common way of
writing the license name in the wider community.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] sound: fix MODULE_LICENSE typos

[Kees Cook]

On Sat, Jun 23, 2012 at 3:51 AM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Fri, Jun 22, 2012 at 04:21:49PM -0700, Kees Cook wrote:
>> include/linux/license.h does not recognize "GPLv2", so adjust these
>> declarations to add the needed space before the version.
>
> This patch isn't against current -next which doesn't have this issue,
> I've no idea what you generated against as a version with this has never
> even been in -next.  Please do also use subject lines that resemble
> those used in the rest of the subsystem, having to hand edit commit logs
> is tedious.
>
> It seems more sensible to fix license.h, GPLv2 is a pretty common way of
> writing the license name in the wider community.

Ah-ha, yes, I see there's already fixed in -next. Thanks!

http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=85f243912b99b053ce0624c30609f5d8fd4445d2

-Kees

-- 
Kees Cook
Chrome OS Security