From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kevin McKinney <klmckinney1@gmail.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org,
Marcos Souza <marcos.souza.org@gmail.com>
Subject: Re: [PATCH 0/3] staging: bcm: Cleanup bcm driver
Date: Tue, 10 Jul 2012 16:31:02 +0300 [thread overview]
Message-ID: <20120710133102.GB6056@mwanda> (raw)
In-Reply-To: <CAKPrQY8ZMSOMDDANKAfXOe6tp+Tnk8Eba=OVpd_z_AFOtJDbtg@mail.gmail.com>
On Tue, Jul 10, 2012 at 09:24:23AM -0400, Kevin McKinney wrote:
> On Tue, Jul 10, 2012 at 8:51 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > On Tue, Jul 10, 2012 at 08:38:41AM -0400, Kevin McKinney wrote:
> >> On Mon, Jul 09, 2012 at 11:48:09PM -0300, Marcos Souza wrote:
> >> > 2012/7/9 Kevin McKinney <klmckinney1@gmail.com>:
> >> > > On Mon, Jul 09, 2012 at 10:32:37PM -0300, Marcos Paulo de Souza wrote:
> >> > >> Hi Kernel guys!
> >> > >>
> >> > >> This new patchset tries to clean a little the bcm driver, removing
> >> > >> some unused macros and some dead code.
> >> > >>
> >> > >> These macros and dead code were reported by the forgotten-macros tool
> >> > >> (https://github.com/marcosps/forgotten_macros).
> >> > >>
> >> > >> The tool is under development, but all the patches looks like OK.
> >> > >>
> >> > >> This patchset is based in staging-next.
> >> > >>
> >> > >> Thanks guys!
> >> > >
> >> > > The patchset looks good!
> >> >
> >> > Thanks for the answer Kevin!!
> >> >
> >> > So, do I have your ack?
> >> Yes, I ack.
> >
> > The normal format is:
> >
> > Acked-by: Your Name <email@address.com>
> >
> > Some maintainers have scripts which pick Acked-by tags automatically
> > or even if they don't they can copy and paste it.
>
> Okay, thanks for this info Dan. I will see if I can write this script.
>
No, what I'm saying is that I know Dave Miller uses a script which
pulls the Acked-by's out of email threads and adds them
automatically. I don't know how Greg does it, but it's better to
use the normal format.
regards,
dan carpenter
next prev parent reply other threads:[~2012-07-10 13:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 1:32 [PATCH 0/3] staging: bcm: Cleanup bcm driver Marcos Paulo de Souza
2012-07-10 1:32 ` [PATCH 1/3] staging: bcm: Remove code that will never execute Marcos Paulo de Souza
2012-07-10 1:32 ` [PATCH 2/3] staging: bcm: Remove all commented macros Marcos Paulo de Souza
2012-07-10 1:32 ` [PATCH 3/3] staging: bcm: Misc.c: Remove unused macros Marcos Paulo de Souza
2012-07-10 2:40 ` [PATCH 0/3] staging: bcm: Cleanup bcm driver Kevin McKinney
2012-07-10 2:48 ` Marcos Souza
2012-07-10 12:38 ` Kevin McKinney
2012-07-10 12:51 ` Dan Carpenter
2012-07-10 13:24 ` Kevin McKinney
2012-07-10 13:31 ` Dan Carpenter [this message]
2012-07-10 13:47 ` Kevin McKinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120710133102.GB6056@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=klmckinney1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcos.souza.org@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox