From: Andres Salomon <dilinger@queued.net>
To: Toshiaki Yamane <yamanetoshi@gmail.com>
Cc: Greg Kroah-Hartman <greg@kroah.com>, Chris Ball <cjb@laptop.org>,
Jon Nettleton <jon.nettleton@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings
Date: Thu, 26 Jul 2012 19:28:03 -0700 [thread overview]
Message-ID: <20120726192803.0afb7eb2@debxo> (raw)
In-Reply-To: <1343346559-8416-1-git-send-email-yamanetoshi@gmail.com>
On Fri, 27 Jul 2012 08:49:19 +0900
Toshiaki Yamane <yamanetoshi@gmail.com> wrote:
> Now checkpatch clean.
>
> $ find drivers/staging/olpc_dcon/ -name
> "*.[ch]"|xargs ./scripts/checkpatch.pl \ -f --terse --nosummary|cut
> -f3- -d":"|sort |uniq -c|sort -n 2 WARNING: msleep < 20ms can sleep
> for up to 20ms; see Documentation/timers/timers-howto.txt 3 WARNING:
NACK - please don't modify the msleep timings right now. The pr_*
changes are welcome, however.
> Prefer pr_debug(... to printk(KERN_DEBUG, ... 3 WARNING: Prefer
> pr_warn(... to printk(KERN_WARNING, ... 6 WARNING: Prefer
> pr_info(... to printk(KERN_INFO, ... 19 WARNING: Prefer pr_err(...
> to printk(KERN_ERR, ...
>
> And added pr_fmt.
>
> Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com>
[...]
next prev parent reply other threads:[~2012-07-27 2:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 23:49 [PATCH] staging/olpc_dcon: fix checkpatch warnings Toshiaki Yamane
2012-07-27 1:40 ` Joe Perches
2012-07-27 2:14 ` Toshiaki Yamane
2012-07-27 2:28 ` Andres Salomon [this message]
2012-07-27 2:42 ` Toshiaki Yamane
2012-07-27 4:46 ` Toshiaki Yamane
2012-07-27 5:03 ` Joe Perches
2012-07-27 5:05 ` Toshiaki Yamane
2012-07-27 11:45 ` Toshiaki Yamane
2012-07-27 18:25 ` Andres Salomon
2012-08-14 2:21 ` Greg Kroah-Hartman
2012-08-17 5:37 ` Toshiaki Yamane
2012-08-17 7:02 ` Andres Salomon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120726192803.0afb7eb2@debxo \
--to=dilinger@queued.net \
--cc=cjb@laptop.org \
--cc=greg@kroah.com \
--cc=jon.nettleton@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yamanetoshi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox