From: Joe Perches <joe@perches.com>
To: Toshiaki Yamane <yamanetoshi@gmail.com>
Cc: Greg Kroah-Hartman <greg@kroah.com>,
Andres Salomon <dilinger@queued.net>, Chris Ball <cjb@laptop.org>,
Jon Nettleton <jon.nettleton@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings
Date: Thu, 26 Jul 2012 18:40:48 -0700 [thread overview]
Message-ID: <1343353248.2271.8.camel@joe2Laptop> (raw)
In-Reply-To: <1343346559-8416-1-git-send-email-yamanetoshi@gmail.com>
On Fri, 2012-07-27 at 08:49 +0900, Toshiaki Yamane wrote:
> Now checkpatch clean.
[]
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
[]
> @@ -11,6 +11,7 @@
[]
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
[]
> @@ -71,18 +72,18 @@ static int dcon_hw_init(struct dcon_priv *dcon, int is_init)
>
> ver = dcon_read(dcon, DCON_REG_ID);
> if ((ver >> 8) != 0xDC) {
> - printk(KERN_ERR "olpc-dcon: DCON ID not 0xDCxx: 0x%04x instead.\n",
> - ver);
> + pr_err("olpc-dcon: DCON ID not 0xDCxx: 0x%04x instead.\n",
> + ver);
> rc = -ENXIO;
> goto err;
> }
>
> if (is_init) {
> - printk(KERN_INFO "olpc-dcon: Discovered DCON version %x\n",
> - ver & 0xFF);
> + pr_info("olpc-dcon: Discovered DCON version %x\n",
> + ver & 0xFF);
Hello.
Please remove all the embedded "olpc-dcon: " prefixes.
There is a pr_fmt define that adds "olpc_dcon" already.
You can use the strings program on the output .o files to
verify the formats that are produced.
next prev parent reply other threads:[~2012-07-27 1:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 23:49 [PATCH] staging/olpc_dcon: fix checkpatch warnings Toshiaki Yamane
2012-07-27 1:40 ` Joe Perches [this message]
2012-07-27 2:14 ` Toshiaki Yamane
2012-07-27 2:28 ` Andres Salomon
2012-07-27 2:42 ` Toshiaki Yamane
2012-07-27 4:46 ` Toshiaki Yamane
2012-07-27 5:03 ` Joe Perches
2012-07-27 5:05 ` Toshiaki Yamane
2012-07-27 11:45 ` Toshiaki Yamane
2012-07-27 18:25 ` Andres Salomon
2012-08-14 2:21 ` Greg Kroah-Hartman
2012-08-17 5:37 ` Toshiaki Yamane
2012-08-17 7:02 ` Andres Salomon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343353248.2271.8.camel@joe2Laptop \
--to=joe@perches.com \
--cc=cjb@laptop.org \
--cc=dilinger@queued.net \
--cc=greg@kroah.com \
--cc=jon.nettleton@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yamanetoshi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox