public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86: Changing date reference in CONFIG_SWIOTLB help from a relative to fixed point
@ 2012-08-05  5:12 Joe Millenbach
  2012-08-06 14:52 ` Konrad Rzeszutek Wilk
  0 siblings, 1 reply; 2+ messages in thread
From: Joe Millenbach @ 2012-08-05  5:12 UTC (permalink / raw)
  To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, linux-kernel
  Cc: team-fjord, Joe Millenbach

CONFIG_SWIOTLB's existing help information refers to "the current
generation of Intel's x86-64 CPUs", but the statement is no longer
true.  After researching on Intel's ark site, I changed the statement
to the also true "all Intel CPUs released before 2008".

Signed-off-by: Joe Millenbach <jmillenbach@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 arch/x86/Kconfig |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 5bed94e..dadbfd6 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -755,10 +755,10 @@ config SWIOTLB
 	def_bool y if X86_64
 	---help---
 	  Support for software bounce buffers used on x86-64 systems
-	  which don't have a hardware IOMMU (e.g. the current generation
-	  of Intel's x86-64 CPUs). Using this PCI devices which can only
-	  access 32-bits of memory can be used on systems with more than
-	  3 GB of memory. If unsure, say Y.
+	  which don't have a hardware IOMMU (e.g. all Intel CPUs released
+	  before 2008). Using this PCI devices which can only access 32-bits
+	  of memory can be used on systems with more than 3 GB of memory. If
+	  unsure, say Y.
 
 config IOMMU_HELPER
 	def_bool (CALGARY_IOMMU || GART_IOMMU || SWIOTLB || AMD_IOMMU)
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] x86: Changing date reference in CONFIG_SWIOTLB help from a relative to fixed point
  2012-08-05  5:12 [PATCH] x86: Changing date reference in CONFIG_SWIOTLB help from a relative to fixed point Joe Millenbach
@ 2012-08-06 14:52 ` Konrad Rzeszutek Wilk
  0 siblings, 0 replies; 2+ messages in thread
From: Konrad Rzeszutek Wilk @ 2012-08-06 14:52 UTC (permalink / raw)
  To: Joe Millenbach
  Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, linux-kernel,
	team-fjord

On Sat, Aug 04, 2012 at 10:12:01PM -0700, Joe Millenbach wrote:
> CONFIG_SWIOTLB's existing help information refers to "the current
> generation of Intel's x86-64 CPUs", but the statement is no longer
> true.  After researching on Intel's ark site, I changed the statement
> to the also true "all Intel CPUs released before 2008".
> 
> Signed-off-by: Joe Millenbach <jmillenbach@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> ---
>  arch/x86/Kconfig |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 5bed94e..dadbfd6 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -755,10 +755,10 @@ config SWIOTLB
>  	def_bool y if X86_64
>  	---help---
>  	  Support for software bounce buffers used on x86-64 systems
> -	  which don't have a hardware IOMMU (e.g. the current generation
> -	  of Intel's x86-64 CPUs). Using this PCI devices which can only
> -	  access 32-bits of memory can be used on systems with more than
> -	  3 GB of memory. If unsure, say Y.
> +	  which don't have a hardware IOMMU (e.g. all Intel CPUs released
> +	  before 2008). Using this PCI devices which can only access 32-bits
> +	  of memory can be used on systems with more than 3 GB of memory. If
> +	  unsure, say Y.

It actually should have that part about Intel CPUs removed - as the hardware
IOMMUs have nothing to do with the CPU. For example the SWIOTLB is used
on the AMD IOMMUs if the IOMMU does not cover certain devices.
So is the case with the IBM Calgary.

>  
>  config IOMMU_HELPER
>  	def_bool (CALGARY_IOMMU || GART_IOMMU || SWIOTLB || AMD_IOMMU)
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-08-06 15:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-05  5:12 [PATCH] x86: Changing date reference in CONFIG_SWIOTLB help from a relative to fixed point Joe Millenbach
2012-08-06 14:52 ` Konrad Rzeszutek Wilk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox