From: Johan Hovold <jhovold@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>, Axel Lin <axel.lin@gmail.com>
Cc: Johan Hovold <jhovold@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: lm3533-als: Fix build warnings
Date: Wed, 22 Aug 2012 11:48:20 +0200 [thread overview]
Message-ID: <20120822094820.GA18415@localhost> (raw)
In-Reply-To: <502AB521.6090201@kernel.org>
On Tue, Aug 14, 2012 at 09:29:21PM +0100, Jonathan Cameron wrote:
> On 08/02/2012 11:10 AM, Axel Lin wrote:
> > Fix below build warnings:
> > CC [M] drivers/iio/light/lm3533-als.o
> > drivers/iio/light/lm3533-als.c:667:8: warning: initialization from incompatible pointer type [enabled by default]
> > drivers/iio/light/lm3533-als.c:667:8: warning: (near initialization for 'dev_attr_in_illuminance0_thresh_either_en.show') [enabled by default]
> > drivers/iio/light/lm3533-als.c:667:8: warning: initialization from incompatible pointer type [enabled by default]
> > drivers/iio/light/lm3533-als.c:667:8: warning: (near initialization for 'dev_attr_in_illuminance0_thresh_either_en.store') [enabled by default]
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
> Thanks queued up.
Thanks for fixing this and sorry for not responding sooner (vacation...).
Johan
> > ---
> > drivers/iio/light/lm3533-als.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c
> > index c3e7bac..e45712a9 100644
> > --- a/drivers/iio/light/lm3533-als.c
> > +++ b/drivers/iio/light/lm3533-als.c
> > @@ -404,7 +404,7 @@ out:
> > return ret;
> > }
> >
> > -static int show_thresh_either_en(struct device *dev,
> > +static ssize_t show_thresh_either_en(struct device *dev,
> > struct device_attribute *attr,
> > char *buf)
> > {
> > @@ -424,7 +424,7 @@ static int show_thresh_either_en(struct device *dev,
> > return scnprintf(buf, PAGE_SIZE, "%u\n", enable);
> > }
> >
> > -static int store_thresh_either_en(struct device *dev,
> > +static ssize_t store_thresh_either_en(struct device *dev,
> > struct device_attribute *attr,
> > const char *buf, size_t len)
> > {
> >
prev parent reply other threads:[~2012-08-22 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 10:10 [PATCH] iio: lm3533-als: Fix build warnings Axel Lin
2012-08-14 20:29 ` Jonathan Cameron
2012-08-22 9:48 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120822094820.GA18415@localhost \
--to=jhovold@gmail.com \
--cc=axel.lin@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox