* [PATCH] iio: lm3533-als: Fix build warnings
@ 2012-08-02 10:10 Axel Lin
2012-08-14 20:29 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2012-08-02 10:10 UTC (permalink / raw)
To: Johan Hovold
Cc: Jonathan Cameron, Greg Kroah-Hartman, linux-iio, linux-kernel
Fix below build warnings:
CC [M] drivers/iio/light/lm3533-als.o
drivers/iio/light/lm3533-als.c:667:8: warning: initialization from incompatible pointer type [enabled by default]
drivers/iio/light/lm3533-als.c:667:8: warning: (near initialization for 'dev_attr_in_illuminance0_thresh_either_en.show') [enabled by default]
drivers/iio/light/lm3533-als.c:667:8: warning: initialization from incompatible pointer type [enabled by default]
drivers/iio/light/lm3533-als.c:667:8: warning: (near initialization for 'dev_attr_in_illuminance0_thresh_either_en.store') [enabled by default]
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/iio/light/lm3533-als.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c
index c3e7bac..e45712a9 100644
--- a/drivers/iio/light/lm3533-als.c
+++ b/drivers/iio/light/lm3533-als.c
@@ -404,7 +404,7 @@ out:
return ret;
}
-static int show_thresh_either_en(struct device *dev,
+static ssize_t show_thresh_either_en(struct device *dev,
struct device_attribute *attr,
char *buf)
{
@@ -424,7 +424,7 @@ static int show_thresh_either_en(struct device *dev,
return scnprintf(buf, PAGE_SIZE, "%u\n", enable);
}
-static int store_thresh_either_en(struct device *dev,
+static ssize_t store_thresh_either_en(struct device *dev,
struct device_attribute *attr,
const char *buf, size_t len)
{
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] iio: lm3533-als: Fix build warnings
2012-08-02 10:10 [PATCH] iio: lm3533-als: Fix build warnings Axel Lin
@ 2012-08-14 20:29 ` Jonathan Cameron
2012-08-22 9:48 ` Johan Hovold
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron @ 2012-08-14 20:29 UTC (permalink / raw)
To: Axel Lin; +Cc: Johan Hovold, Greg Kroah-Hartman, linux-iio, linux-kernel
On 08/02/2012 11:10 AM, Axel Lin wrote:
> Fix below build warnings:
> CC [M] drivers/iio/light/lm3533-als.o
> drivers/iio/light/lm3533-als.c:667:8: warning: initialization from incompatible pointer type [enabled by default]
> drivers/iio/light/lm3533-als.c:667:8: warning: (near initialization for 'dev_attr_in_illuminance0_thresh_either_en.show') [enabled by default]
> drivers/iio/light/lm3533-als.c:667:8: warning: initialization from incompatible pointer type [enabled by default]
> drivers/iio/light/lm3533-als.c:667:8: warning: (near initialization for 'dev_attr_in_illuminance0_thresh_either_en.store') [enabled by default]
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Thanks queued up.
> ---
> drivers/iio/light/lm3533-als.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c
> index c3e7bac..e45712a9 100644
> --- a/drivers/iio/light/lm3533-als.c
> +++ b/drivers/iio/light/lm3533-als.c
> @@ -404,7 +404,7 @@ out:
> return ret;
> }
>
> -static int show_thresh_either_en(struct device *dev,
> +static ssize_t show_thresh_either_en(struct device *dev,
> struct device_attribute *attr,
> char *buf)
> {
> @@ -424,7 +424,7 @@ static int show_thresh_either_en(struct device *dev,
> return scnprintf(buf, PAGE_SIZE, "%u\n", enable);
> }
>
> -static int store_thresh_either_en(struct device *dev,
> +static ssize_t store_thresh_either_en(struct device *dev,
> struct device_attribute *attr,
> const char *buf, size_t len)
> {
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] iio: lm3533-als: Fix build warnings
2012-08-14 20:29 ` Jonathan Cameron
@ 2012-08-22 9:48 ` Johan Hovold
0 siblings, 0 replies; 3+ messages in thread
From: Johan Hovold @ 2012-08-22 9:48 UTC (permalink / raw)
To: Jonathan Cameron, Axel Lin
Cc: Johan Hovold, Greg Kroah-Hartman, linux-iio, linux-kernel
On Tue, Aug 14, 2012 at 09:29:21PM +0100, Jonathan Cameron wrote:
> On 08/02/2012 11:10 AM, Axel Lin wrote:
> > Fix below build warnings:
> > CC [M] drivers/iio/light/lm3533-als.o
> > drivers/iio/light/lm3533-als.c:667:8: warning: initialization from incompatible pointer type [enabled by default]
> > drivers/iio/light/lm3533-als.c:667:8: warning: (near initialization for 'dev_attr_in_illuminance0_thresh_either_en.show') [enabled by default]
> > drivers/iio/light/lm3533-als.c:667:8: warning: initialization from incompatible pointer type [enabled by default]
> > drivers/iio/light/lm3533-als.c:667:8: warning: (near initialization for 'dev_attr_in_illuminance0_thresh_either_en.store') [enabled by default]
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
> Thanks queued up.
Thanks for fixing this and sorry for not responding sooner (vacation...).
Johan
> > ---
> > drivers/iio/light/lm3533-als.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c
> > index c3e7bac..e45712a9 100644
> > --- a/drivers/iio/light/lm3533-als.c
> > +++ b/drivers/iio/light/lm3533-als.c
> > @@ -404,7 +404,7 @@ out:
> > return ret;
> > }
> >
> > -static int show_thresh_either_en(struct device *dev,
> > +static ssize_t show_thresh_either_en(struct device *dev,
> > struct device_attribute *attr,
> > char *buf)
> > {
> > @@ -424,7 +424,7 @@ static int show_thresh_either_en(struct device *dev,
> > return scnprintf(buf, PAGE_SIZE, "%u\n", enable);
> > }
> >
> > -static int store_thresh_either_en(struct device *dev,
> > +static ssize_t store_thresh_either_en(struct device *dev,
> > struct device_attribute *attr,
> > const char *buf, size_t len)
> > {
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-08-22 9:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-02 10:10 [PATCH] iio: lm3533-als: Fix build warnings Axel Lin
2012-08-14 20:29 ` Jonathan Cameron
2012-08-22 9:48 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox