* re: memstick: add support for legacy memorysticks
@ 2012-09-21 11:37 Dan Carpenter
2012-09-21 11:39 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-09-21 11:37 UTC (permalink / raw)
To: maximlevitsky; +Cc: linux-kernel, Andrew Morton
Hello Maxim Levitsky,
The patch d59dd7c61b24: "memstick: add support for legacy
memorysticks" from Sep 21, 2012, leads to the following warning:
drivers/memstick/core/ms_block.c:147 sg_compare_to_buffer()
warn: signedness bug returning '-1'
141
142 if (!retval && len)
143 retval = -1;
^^^^^^^^^^^
144
145 sg_miter_stop(&miter);
146 local_irq_restore(flags);
147 return retval;
148 }
This function is bool so it always returns true if len is non-zero.
The comments at the top of the function don't talk about if a 1 means
the same and 0 means different or if it's the other way around.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-21 11:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-21 11:37 memstick: add support for legacy memorysticks Dan Carpenter
2012-09-21 11:39 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox