* [patch 2/3] remoteproc: snprintf() can return more than was printed
@ 2012-09-25 7:02 Dan Carpenter
2012-09-30 9:40 ` Ohad Ben-Cohen
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-09-25 7:02 UTC (permalink / raw)
To: Ohad Ben-Cohen; +Cc: linux-kernel, kernel-janitors
snprintf() returns the number of characters which would have been
printed if there were enough space. For example, on the first print if
we fill up the 28 character string then it would return a number more
than 30. Use scnprintf() instead because that returns the actual number
of characters printed.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c
index 10a3825..ea90a56 100644
--- a/drivers/remoteproc/remoteproc_debugfs.c
+++ b/drivers/remoteproc/remoteproc_debugfs.c
@@ -82,7 +82,7 @@ static ssize_t rproc_state_read(struct file *filp, char __user *userbuf,
state = rproc->state > RPROC_LAST ? RPROC_LAST : rproc->state;
- i = snprintf(buf, 30, "%.28s (%d)\n", rproc_state_string[state],
+ i = scnprintf(buf, 30, "%.28s (%d)\n", rproc_state_string[state],
rproc->state);
return simple_read_from_buffer(userbuf, count, ppos, buf, i);
@@ -103,7 +103,7 @@ static ssize_t rproc_name_read(struct file *filp, char __user *userbuf,
char buf[100];
int i;
- i = snprintf(buf, sizeof(buf), "%.98s\n", rproc->name);
+ i = scnprintf(buf, sizeof(buf), "%.98s\n", rproc->name);
return simple_read_from_buffer(userbuf, count, ppos, buf, i);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch 2/3] remoteproc: snprintf() can return more than was printed
2012-09-25 7:02 [patch 2/3] remoteproc: snprintf() can return more than was printed Dan Carpenter
@ 2012-09-30 9:40 ` Ohad Ben-Cohen
0 siblings, 0 replies; 2+ messages in thread
From: Ohad Ben-Cohen @ 2012-09-30 9:40 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-kernel, kernel-janitors
On Tue, Sep 25, 2012 at 9:02 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> snprintf() returns the number of characters which would have been
> printed if there were enough space. For example, on the first print if
> we fill up the 28 character string then it would return a number more
> than 30. Use scnprintf() instead because that returns the actual number
> of characters printed.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-30 9:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-25 7:02 [patch 2/3] remoteproc: snprintf() can return more than was printed Dan Carpenter
2012-09-30 9:40 ` Ohad Ben-Cohen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox