From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Vince Weaver <vincent.weaver@maine.edu>
Cc: linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
eranian@gmail.com, "Meadows,
Lawrence F" <lawrence.f.meadows@intel.com>
Subject: Re: [PATCH 1/1] perf, Add support for Xeon-Phi PMU
Date: Tue, 25 Sep 2012 17:27:54 +0400 [thread overview]
Message-ID: <20120925132754.GJ14490@moon> (raw)
In-Reply-To: <1348574486.3881.43.camel@twins>
On Tue, Sep 25, 2012 at 02:01:26PM +0200, Peter Zijlstra wrote:
> On Tue, 2012-09-25 at 15:42 +0400, Cyrill Gorcunov wrote:
>
> > Guys, letme re-read this whole mail thread first since I have no clue
> > what this remapping about ;)
>
> x86_setup_perfctr() / set_ext_hw_attr() have special purposed 0 and -1
> config values to mean -ENOENT and -EINVAL resp.
>
> This means neither config value can be a 'real' event. Now it turns out
> Xeon-Phi has an actual event 0, which is masked by these special case
> thingies.
So guys, if understand all things correctly it's supposed to use some
-1/-2 as initial @config value for unsupported events, right? Vince,
may not it be easier to use bit 19 as a flag of valid event and clear
it when you write to msr, thus we will not have to change "zero is reserved"
semantics (otoh i'm not sure if it won't become a problem somewhere in
future with some new cpu :)
next prev parent reply other threads:[~2012-09-25 13:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 17:03 [PATCH 1/1] perf, Add support for Xeon-Phi PMU Vince Weaver
2012-09-24 17:48 ` Meadows, Lawrence F
2012-09-25 11:32 ` Peter Zijlstra
2012-09-25 11:42 ` Cyrill Gorcunov
2012-09-25 11:51 ` Cyrill Gorcunov
2012-09-25 12:01 ` Peter Zijlstra
2012-09-25 12:05 ` stephane eranian
2012-09-25 12:22 ` Cyrill Gorcunov
2012-09-25 12:23 ` Cyrill Gorcunov
2012-09-25 13:27 ` Cyrill Gorcunov [this message]
2012-09-25 14:45 ` Vince Weaver
2012-09-25 14:53 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120925132754.GJ14490@moon \
--to=gorcunov@openvz.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=eranian@gmail.com \
--cc=lawrence.f.meadows@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox