From: Dan Carpenter <dan.carpenter@oracle.com>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
ldv-project@linuxtesting.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging/gdm72xx: coding style fixes gdm_qos.c
Date: Tue, 25 Sep 2012 16:30:33 +0300 [thread overview]
Message-ID: <20120925133033.GT4587@mwanda> (raw)
In-Reply-To: <1348577632-25462-1-git-send-email-khoroshilov@ispras.ru>
On Tue, Sep 25, 2012 at 04:53:52PM +0400, Alexey Khoroshilov wrote:
> Fix checkpatch.pl warnings:
> WARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ...
> WARNING: Prefer pr_warn(... to printk(KERN_WARNING, ...
> WARNING: Prefer pr_err(... to printk(KERN_ERR, ...
>
Better to just replace the dprintk macros instead of prettifying
them.
regards,
dan carpenter
prev parent reply other threads:[~2012-09-25 13:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 12:53 [PATCH] staging/gdm72xx: coding style fixes gdm_qos.c Alexey Khoroshilov
2012-09-25 13:30 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120925133033.GT4587@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=khoroshilov@ispras.ru \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox