* [PATCH] staging/gdm72xx: coding style fixes gdm_qos.c
@ 2012-09-25 12:53 Alexey Khoroshilov
2012-09-25 13:30 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Khoroshilov @ 2012-09-25 12:53 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Alexey Khoroshilov, open list:STAGING SUBSYSTEM, open list,
ldv-project
Fix checkpatch.pl warnings:
WARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ...
WARNING: Prefer pr_warn(... to printk(KERN_WARNING, ...
WARNING: Prefer pr_err(... to printk(KERN_ERR, ...
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---
drivers/staging/gdm72xx/gdm_qos.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging/gdm72xx/gdm_qos.c
index 80bde05..ed60138 100644
--- a/drivers/staging/gdm72xx/gdm_qos.c
+++ b/drivers/staging/gdm72xx/gdm_qos.c
@@ -25,12 +25,12 @@
#define B2H(x) __be16_to_cpu(x)
#undef dprintk
-#define dprintk(fmt, args ...) printk(KERN_DEBUG "[QoS] " fmt, ## args)
+#define dprintk(fmt, args ...) pr_debug("[QoS] " fmt, ## args)
#undef wprintk
#define wprintk(fmt, args ...) \
- printk(KERN_WARNING "[QoS WARNING] " fmt, ## args)
+ pr_warn("[QoS WARNING] " fmt, ## args)
#undef eprintk
-#define eprintk(fmt, args ...) printk(KERN_ERR "[QoS ERROR] " fmt, ## args)
+#define eprintk(fmt, args ...) pr_err("[QoS ERROR] " fmt, ## args)
#define MAX_FREE_LIST_CNT 32
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging/gdm72xx: coding style fixes gdm_qos.c
2012-09-25 12:53 [PATCH] staging/gdm72xx: coding style fixes gdm_qos.c Alexey Khoroshilov
@ 2012-09-25 13:30 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2012-09-25 13:30 UTC (permalink / raw)
To: Alexey Khoroshilov
Cc: Greg Kroah-Hartman, open list:STAGING SUBSYSTEM, ldv-project,
open list
On Tue, Sep 25, 2012 at 04:53:52PM +0400, Alexey Khoroshilov wrote:
> Fix checkpatch.pl warnings:
> WARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ...
> WARNING: Prefer pr_warn(... to printk(KERN_WARNING, ...
> WARNING: Prefer pr_err(... to printk(KERN_ERR, ...
>
Better to just replace the dprintk macros instead of prettifying
them.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-25 13:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-25 12:53 [PATCH] staging/gdm72xx: coding style fixes gdm_qos.c Alexey Khoroshilov
2012-09-25 13:30 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox