The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Bernhard Walle <bernhard@bwalle.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: Jean Delvare <jdelvare@suse.de>,
	linux-kernel@vger.kernel.org, x86@kernel.org,
	Michal Marek <mmarek@suse.cz>, Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] kbuild: Fix gcc -x syntax
Date: Sat, 29 Sep 2012 09:24:59 +0100	[thread overview]
Message-ID: <20120929082459.GA10005@brahe.fritz.box> (raw)
In-Reply-To: <20120929073749.GA7672@gmail.com>

Hi,

* Ingo Molnar <mingo@kernel.org> [2012-09-29 08:37]:
> * Jean Delvare <jdelvare@suse.de> wrote:
> 
> > The correct syntax for gcc -x is "gcc -x assembler", not "gcc 
> > -xassembler". Even though the latter happens to work, the 
> > former is what is documented in the manual page and thus what 
> > gcc wrappers such as icecream do expect.
> > 
> > This isn't a cosmetic change. The missing space prevents 
> > icecream from recognizing compilation tasks it can't handle, 
> > leading to silent kernel miscompilations.
> 
> Although we can apply this patch, it won't solve the problem of 
> building older kernels (and bisecting, etc.).
> 
> Wouldn't it be prudent to increase the compatibility of 
> icecream, so that it accepts what GCC accepts in practice,
> such as -xassembler?

Wouldn't it make sense to do both? Using the documented syntax in the
build system *and* increase compatibility in 3rd party tools?


Regards,
Bernhard

  reply	other threads:[~2012-09-29  8:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-28 19:12 [PATCH] kbuild: Fix gcc -x syntax Jean Delvare
2012-09-29  7:37 ` Ingo Molnar
2012-09-29  8:24   ` Bernhard Walle [this message]
2012-09-29  8:34     ` Ingo Molnar
2012-09-29 11:46     ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120929082459.GA10005@brahe.fritz.box \
    --to=bernhard@bwalle.de \
    --cc=jdelvare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mmarek@suse.cz \
    --cc=ralf@linux-mips.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox