Re: [PATCH] rcu: Remove rcu_switch()

[Frederic Weisbecker <fweisbec@gmail.com>]

On Wed, Oct 03, 2012 at 11:39:45AM -0700, Paul E. McKenney wrote:
> On Wed, Oct 03, 2012 at 08:21:52PM +0200, Frederic Weisbecker wrote:
> > It's only there to call rcu_user_hooks_switch(). Let's
> > just call rcu_user_hooks_switch() directly, we don't need this
> > function in the middle.
> 
> Hello, Frederic!
> 
> Doesn't this also require an empty definition of rcu_user_hooks_switch()
> to handle the CONFIG_RCU_USER_QS=n case?  Or is there already such
> a definition that I am too blind to see?

There is, look below:

> 
> 							Thanx, Paul
> 
> > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> > Cc: Josh Triplett <josh@joshtriplett.org>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > ---
> >  include/linux/rcupdate.h |    2 ++
> >  include/linux/sched.h    |    8 --------
> >  kernel/sched/core.c      |    2 +-
> >  3 files changed, 3 insertions(+), 9 deletions(-)
> > 
> > diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
> > index 7c968e4..5d009de 100644
> > --- a/include/linux/rcupdate.h
> > +++ b/include/linux/rcupdate.h
> > @@ -204,6 +204,8 @@ static inline void rcu_user_enter(void) { }
> >  static inline void rcu_user_exit(void) { }
> >  static inline void rcu_user_enter_after_irq(void) { }
> >  static inline void rcu_user_exit_after_irq(void) { }
> > +static inline void rcu_user_hooks_switch(struct task_struct *prev,
> > +					 struct task_struct *next) { }

Here.

> >  #endif /* CONFIG_RCU_USER_QS */