From: Greg Kroah-Hartman <greg@kroah.com>
To: YAMANE Toshiaki <yamanetoshi@gmail.com>
Cc: Ian Abbott <abbotti@mev.co.uk>,
Frank Mori Hess <fmhess@users.sourceforge.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/comedi: Use dev_ printks in drivers/vmk80xx.c
Date: Mon, 22 Oct 2012 12:45:37 -0700 [thread overview]
Message-ID: <20121022194537.GB30479@kroah.com> (raw)
In-Reply-To: <1350298686-20770-1-git-send-email-yamanetoshi@gmail.com>
On Mon, Oct 15, 2012 at 07:58:06PM +0900, YAMANE Toshiaki wrote:
> - printk(KERN_INFO "comedi#: vmk80xx: board #%d [%s] now attached\n",
> - dev->count, dev->board.name);
> + dev_info(&intf->dev, "vmk80xx: board #%d [%s] now attached\n",
> + dev->count, dev->board.name);
The vmk80xx here is redundant, as it shows up from the dev_info()
printk. Care to fix the two places here you did that and resend?
Note, when you resend please enumerate what version of the patch this
is, otherwise I can get very confused.
thanks,
greg k-h
next prev parent reply other threads:[~2012-10-22 19:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-14 13:40 [PATCH] staging/comedi: Use dev_ printks in drivers/vmk80xx.c YAMANE Toshiaki
2012-10-15 9:19 ` Ian Abbott
2012-10-15 10:58 ` YAMANE Toshiaki
2012-10-22 19:45 ` Greg Kroah-Hartman [this message]
2012-10-24 3:14 ` Toshiaki Yamane
2012-10-24 5:21 ` [PATCH v2] " YAMANE Toshiaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121022194537.GB30479@kroah.com \
--to=greg@kroah.com \
--cc=abbotti@mev.co.uk \
--cc=fmhess@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yamanetoshi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox