From: Ian Abbott <abbotti@mev.co.uk>
To: YAMANE Toshiaki <yamanetoshi@gmail.com>
Cc: Greg Kroah-Hartman <greg@kroah.com>,
Ian Abbott <ian.abbott@mev.co.uk>,
Frank Mori Hess <fmhess@users.sourceforge.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging/comedi: Use dev_ printks in drivers/vmk80xx.c
Date: Mon, 15 Oct 2012 10:19:57 +0100 [thread overview]
Message-ID: <507BD53D.2070407@mev.co.uk> (raw)
In-Reply-To: <1350222055-7666-1-git-send-email-yamanetoshi@gmail.com>
On 2012/10/14 02:40 PM, YAMANE Toshiaki wrote:
> fixed below checkpatch warning.
> - Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
>
> Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
> ---
> drivers/staging/comedi/drivers/vmk80xx.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/vmk80xx.c b/drivers/staging/comedi/drivers/vmk80xx.c
> index df277aa..3e77d40 100644
> --- a/drivers/staging/comedi/drivers/vmk80xx.c
> +++ b/drivers/staging/comedi/drivers/vmk80xx.c
> @@ -1371,12 +1371,12 @@ static int vmk80xx_usb_probe(struct usb_interface *intf,
>
> if (dev->board.model == VMK8061_MODEL) {
> vmk80xx_read_eeprom(dev, IC3_VERSION);
> - printk(KERN_INFO "comedi#: vmk80xx: %s\n", dev->fw.ic3_vers);
> + dev_info(&intf->dev, "%s: %s\n", __FILE__, dev->fw.ic3_vers);
I think __FILE__ is the wrong thing to use in these logs. Better to use
vmk80xx or perhaps KBUILD_MODNAME.
>
> if (vmk80xx_check_data_link(dev)) {
> vmk80xx_read_eeprom(dev, IC6_VERSION);
> - printk(KERN_INFO "comedi#: vmk80xx: %s\n",
> - dev->fw.ic6_vers);
> + dev_info(&intf->dev, "%s: %s\n",
> + __FILE__, dev->fw.ic6_vers);
> } else {
> dbgcm("comedi#: vmk80xx: no conn. to CPU\n");
> }
> @@ -1387,8 +1387,8 @@ static int vmk80xx_usb_probe(struct usb_interface *intf,
>
> dev->probed = 1;
>
> - printk(KERN_INFO "comedi#: vmk80xx: board #%d [%s] now attached\n",
> - dev->count, dev->board.name);
> + dev_info(&intf->dev, "%s: board #%d [%s] now attached\n",
> + __FILE__, dev->count, dev->board.name);
>
> mutex_unlock(&glb_mutex);
>
> @@ -1422,8 +1422,8 @@ static void vmk80xx_usb_disconnect(struct usb_interface *intf)
> kfree(dev->usb_rx_buf);
> kfree(dev->usb_tx_buf);
>
> - printk(KERN_INFO "comedi#: vmk80xx: board #%d [%s] now detached\n",
> - dev->count, dev->board.name);
> + dev_info(&intf->dev, "%s: board #%d [%s] now detached\n",
> + __FILE__, dev->count, dev->board.name);
>
> up(&dev->limit_sem);
> mutex_unlock(&glb_mutex);
>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
next prev parent reply other threads:[~2012-10-15 9:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-14 13:40 [PATCH] staging/comedi: Use dev_ printks in drivers/vmk80xx.c YAMANE Toshiaki
2012-10-15 9:19 ` Ian Abbott [this message]
2012-10-15 10:58 ` YAMANE Toshiaki
2012-10-22 19:45 ` Greg Kroah-Hartman
2012-10-24 3:14 ` Toshiaki Yamane
2012-10-24 5:21 ` [PATCH v2] " YAMANE Toshiaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507BD53D.2070407@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=fmhess@users.sourceforge.net \
--cc=greg@kroah.com \
--cc=ian.abbott@mev.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=yamanetoshi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox