[PATCH] Documentation/SubmittingPatches: implicit permission for public reports

[PATCH] Documentation/SubmittingPatches: implicit permission for public reports

[Ed Cashin, Ed Cashin]

The current text of SubmittingPatches recommends asking permission
before using "Reported-By:" even when the report was made to a
public forum.  This patch updates the text to better reflect the
current convention of including the tag when the report was public.

Signed-off-by: Ed Cashin <ecashin@coraid.com>
---
 Documentation/SubmittingPatches |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index c379a2a..d30b692 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -423,12 +423,12 @@ have been included in the discussion
 
 14) Using Reported-by:, Tested-by: and Reviewed-by:
 
-If this patch fixes a problem reported by somebody else, consider adding a
-Reported-by: tag to credit the reporter for their contribution.  Please
-note that this tag should not be added without the reporter's permission,
-especially if the problem was not reported in a public forum.  That said,
-if we diligently credit our bug reporters, they will, hopefully, be
-inspired to help us again in the future.
+If this patch fixes a problem reported by somebody else, consider
+adding a Reported-by: tag to credit the reporter for their
+contribution.  Please note that this tag should not be added without
+the reporter's permission unless the problem was reported in a public
+forum.  That said, if we diligently credit our bug reporters, they
+will, hopefully, be inspired to help us again in the future.
 
 A Tested-by: tag indicates that the patch has been successfully tested (in
 some environment) by the person named.  This tag informs maintainers that
-- 
1.7.1

Re: [PATCH] Documentation/SubmittingPatches: implicit permission for public reports

[Jonathan Corbet]

On Wed, 24 Oct 2012 10:22:02 -0400
Ed Cashin <ecashin@coraid.com> wrote:

> +contribution.  Please note that this tag should not be added without
> +the reporter's permission unless the problem was reported in a public
> +forum.  That said, if we diligently credit our bug reporters, they

I know what you're getting at, but this reads as if one should add the tag
even if it's contrary to the reporter's wishes.  How about something like:

	If the bug report was via a private channel, please obtain the
	reporter's permission before adding this tag - or, even better,
	ask that the report be posted publicly.

?

jon

Re: [PATCH] Documentation/SubmittingPatches: implicit permission for public reports

[Ed Cashin]

On Oct 24, 2012, at 10:36 AM, Jonathan Corbet wrote:

> On Wed, 24 Oct 2012 10:22:02 -0400
> Ed Cashin <ecashin@coraid.com> wrote:
> 
>> +contribution.  Please note that this tag should not be added without
>> +the reporter's permission unless the problem was reported in a public
>> +forum.  That said, if we diligently credit our bug reporters, they
> 
> I know what you're getting at, but this reads as if one should add the tag
> even if it's contrary to the reporter's wishes.  How about something like:
> 
> 	If the bug report was via a private channel, please obtain the
> 	reporter's permission before adding this tag - or, even better,
> 	ask that the report be posted publicly.
> 
> ?

Yes, that's a great improvement, thanks!

-- 
  Ed Cashin
  ecashin@coraid.com