* Fix memory leak in sierra_release() (this time with signed-off-by)
@ 2012-10-24 14:23 Lennart Sorensen
2012-10-24 14:56 ` Johan Hovold
0 siblings, 1 reply; 3+ messages in thread
From: Lennart Sorensen @ 2012-10-24 14:23 UTC (permalink / raw)
To: linux-kernel; +Cc: Bjørn Mork, Len Sorensen, linux, linux-usb
I found a memory leak in sierra_release() (well sierra_probe() I guess)
that looses 8 bytes each time the driver releases a device.
Signed-off-by: Len Sorensen <lsorense@csclub.uwaterloo.ca>
diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
index 01d882c..76ef95b 100644
--- a/drivers/usb/serial/sierra.c
+++ b/drivers/usb/serial/sierra.c
@@ -959,6 +959,7 @@ static void sierra_release(struct usb_serial *serial)
continue;
kfree(portdata);
}
+ kfree(serial->private);
}
#ifdef CONFIG_PM
--
Len Sorensen
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: Fix memory leak in sierra_release() (this time with signed-off-by)
2012-10-24 14:23 Fix memory leak in sierra_release() (this time with signed-off-by) Lennart Sorensen
@ 2012-10-24 14:56 ` Johan Hovold
2012-10-24 16:06 ` Lennart Sorensen
0 siblings, 1 reply; 3+ messages in thread
From: Johan Hovold @ 2012-10-24 14:56 UTC (permalink / raw)
To: Lennart Sorensen; +Cc: linux-kernel, Bjørn Mork, linux, linux-usb, Greg KH
On Wed, Oct 24, 2012 at 10:23:09AM -0400, Lennart Sorensen wrote:
> I found a memory leak in sierra_release() (well sierra_probe() I guess)
> that looses 8 bytes each time the driver releases a device.
Good catch! I missed this one when I fixed a bunch of other memory
leaks in the sierra with recent kernels:
http://marc.info/?l=linux-usb&m=135100550421848&w=2
I'll rebase my patch on top of this one as your patch should be
backported to all stable kernels, whereas mine is only required for
v3.6 and later.
> Signed-off-by: Len Sorensen <lsorense@csclub.uwaterloo.ca>
Cc: <stable@vger.kernel.org>
Acked-by: Johan Hovold <jhovold@gmail.com>
Thanks,
Johan
> diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
> index 01d882c..76ef95b 100644
> --- a/drivers/usb/serial/sierra.c
> +++ b/drivers/usb/serial/sierra.c
> @@ -959,6 +959,7 @@ static void sierra_release(struct usb_serial *serial)
> continue;
> kfree(portdata);
> }
> + kfree(serial->private);
> }
>
> #ifdef CONFIG_PM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Fix memory leak in sierra_release() (this time with signed-off-by)
2012-10-24 14:56 ` Johan Hovold
@ 2012-10-24 16:06 ` Lennart Sorensen
0 siblings, 0 replies; 3+ messages in thread
From: Lennart Sorensen @ 2012-10-24 16:06 UTC (permalink / raw)
To: Johan Hovold; +Cc: linux-kernel, Bjørn Mork, linux, linux-usb, Greg KH
On Wed, Oct 24, 2012 at 04:56:44PM +0200, Johan Hovold wrote:
> Good catch! I missed this one when I fixed a bunch of other memory
> leaks in the sierra with recent kernels:
>
> http://marc.info/?l=linux-usb&m=135100550421848&w=2
>
> I'll rebase my patch on top of this one as your patch should be
> backported to all stable kernels, whereas mine is only required for
> v3.6 and later.
Oh that looks useful. I was trying to track down if there were more
leaks in the driver. I just fixed the one that was most obvious to me.
--
Len Sorensen
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-24 16:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-24 14:23 Fix memory leak in sierra_release() (this time with signed-off-by) Lennart Sorensen
2012-10-24 14:56 ` Johan Hovold
2012-10-24 16:06 ` Lennart Sorensen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox