* [PATCH 1/2] ARM: ux500: Disable the MMCI gpio-regulator by default
@ 2012-11-15 13:14 Lee Jones
2012-11-15 13:14 ` [PATCH 2/2] ARM: ux500: Move board specific GPIO info out to subordinate DTS files Lee Jones
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Lee Jones @ 2012-11-15 13:14 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel; +Cc: arnd, linus.walleij, Lee Jones
Not all supported boards will require a MMCI gpio-regulator,
therefore it's a good idea to only enable the node when and if
it is required. Let's disable it by default.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
arch/arm/boot/dts/dbx5x0.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi
index 7ce45fc..d8ba489 100644
--- a/arch/arm/boot/dts/dbx5x0.dtsi
+++ b/arch/arm/boot/dts/dbx5x0.dtsi
@@ -642,6 +642,8 @@
gpio-enable = <&tc3589x_gpio 17 0x4>;
states = <1800000 0x1
2900000 0x0>;
+
+ status = "disabled";
};
};
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] ARM: ux500: Move board specific GPIO info out to subordinate DTS files
2012-11-15 13:14 [PATCH 1/2] ARM: ux500: Disable the MMCI gpio-regulator by default Lee Jones
@ 2012-11-15 13:14 ` Lee Jones
2012-11-20 16:08 ` Lee Jones
2012-11-20 22:38 ` Linus Walleij
2012-11-20 16:08 ` [PATCH 1/2] ARM: ux500: Disable the MMCI gpio-regulator by default Lee Jones
2012-11-20 22:37 ` Linus Walleij
2 siblings, 2 replies; 6+ messages in thread
From: Lee Jones @ 2012-11-15 13:14 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel; +Cc: arnd, linus.walleij, Lee Jones
GPIO numbers for the newly created gpio-regulator will differ from
board to board. Therefore it's not sensible to leave this information
in the top level DTSI file. Let's move them out to the DTS files
where they can correctly vary.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
arch/arm/boot/dts/dbx5x0.dtsi | 2 --
arch/arm/boot/dts/hrefprev60.dts | 7 +++++++
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi
index d8ba489..9f55363 100644
--- a/arch/arm/boot/dts/dbx5x0.dtsi
+++ b/arch/arm/boot/dts/dbx5x0.dtsi
@@ -638,8 +638,6 @@
regulator-name = "mmci-reg";
regulator-type = "voltage";
- gpios = <&tc3589x_gpio 18 0x4>;
- gpio-enable = <&tc3589x_gpio 17 0x4>;
states = <1800000 0x1
2900000 0x0>;
diff --git a/arch/arm/boot/dts/hrefprev60.dts b/arch/arm/boot/dts/hrefprev60.dts
index b398946..eec29c4 100644
--- a/arch/arm/boot/dts/hrefprev60.dts
+++ b/arch/arm/boot/dts/hrefprev60.dts
@@ -37,5 +37,12 @@
reset-gpio = <&tc3589x_gpio 13 0x4>;
};
};
+
+ vmmci: regulator-gpio {
+ gpios = <&tc3589x_gpio 18 0x4>;
+ gpio-enable = <&tc3589x_gpio 17 0x4>;
+
+ status = "okay";
+ };
};
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] ARM: ux500: Move board specific GPIO info out to subordinate DTS files
2012-11-15 13:14 ` [PATCH 2/2] ARM: ux500: Move board specific GPIO info out to subordinate DTS files Lee Jones
@ 2012-11-20 16:08 ` Lee Jones
2012-11-20 22:38 ` Linus Walleij
1 sibling, 0 replies; 6+ messages in thread
From: Lee Jones @ 2012-11-20 16:08 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel; +Cc: arnd, linus.walleij
On Thu, 15 Nov 2012, Lee Jones wrote:
> GPIO numbers for the newly created gpio-regulator will differ from
> board to board. Therefore it's not sensible to leave this information
> in the top level DTSI file. Let's move them out to the DTS files
> where they can correctly vary.
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> arch/arm/boot/dts/dbx5x0.dtsi | 2 --
> arch/arm/boot/dts/hrefprev60.dts | 7 +++++++
> 2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi
> index d8ba489..9f55363 100644
> --- a/arch/arm/boot/dts/dbx5x0.dtsi
> +++ b/arch/arm/boot/dts/dbx5x0.dtsi
> @@ -638,8 +638,6 @@
> regulator-name = "mmci-reg";
> regulator-type = "voltage";
>
> - gpios = <&tc3589x_gpio 18 0x4>;
> - gpio-enable = <&tc3589x_gpio 17 0x4>;
> states = <1800000 0x1
> 2900000 0x0>;
>
> diff --git a/arch/arm/boot/dts/hrefprev60.dts b/arch/arm/boot/dts/hrefprev60.dts
> index b398946..eec29c4 100644
> --- a/arch/arm/boot/dts/hrefprev60.dts
> +++ b/arch/arm/boot/dts/hrefprev60.dts
> @@ -37,5 +37,12 @@
> reset-gpio = <&tc3589x_gpio 13 0x4>;
> };
> };
> +
> + vmmci: regulator-gpio {
> + gpios = <&tc3589x_gpio 18 0x4>;
> + gpio-enable = <&tc3589x_gpio 17 0x4>;
> +
> + status = "okay";
> + };
> };
> };
> --
> 1.7.9.5
Prod for Linus.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] ARM: ux500: Move board specific GPIO info out to subordinate DTS files
2012-11-15 13:14 ` [PATCH 2/2] ARM: ux500: Move board specific GPIO info out to subordinate DTS files Lee Jones
2012-11-20 16:08 ` Lee Jones
@ 2012-11-20 22:38 ` Linus Walleij
1 sibling, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2012-11-20 22:38 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-arm-kernel, linux-kernel, arnd, linus.walleij
On Thu, Nov 15, 2012 at 2:14 PM, Lee Jones <lee.jones@linaro.org> wrote:
> GPIO numbers for the newly created gpio-regulator will differ from
> board to board. Therefore it's not sensible to leave this information
> in the top level DTSI file. Let's move them out to the DTS files
> where they can correctly vary.
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ARM: ux500: Disable the MMCI gpio-regulator by default
2012-11-15 13:14 [PATCH 1/2] ARM: ux500: Disable the MMCI gpio-regulator by default Lee Jones
2012-11-15 13:14 ` [PATCH 2/2] ARM: ux500: Move board specific GPIO info out to subordinate DTS files Lee Jones
@ 2012-11-20 16:08 ` Lee Jones
2012-11-20 22:37 ` Linus Walleij
2 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2012-11-20 16:08 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel; +Cc: arnd, linus.walleij
On Thu, 15 Nov 2012, Lee Jones wrote:
> Not all supported boards will require a MMCI gpio-regulator,
> therefore it's a good idea to only enable the node when and if
> it is required. Let's disable it by default.
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> arch/arm/boot/dts/dbx5x0.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi
> index 7ce45fc..d8ba489 100644
> --- a/arch/arm/boot/dts/dbx5x0.dtsi
> +++ b/arch/arm/boot/dts/dbx5x0.dtsi
> @@ -642,6 +642,8 @@
> gpio-enable = <&tc3589x_gpio 17 0x4>;
> states = <1800000 0x1
> 2900000 0x0>;
> +
> + status = "disabled";
> };
> };
> };
> --
> 1.7.9.5
>
Prod for Linus.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ARM: ux500: Disable the MMCI gpio-regulator by default
2012-11-15 13:14 [PATCH 1/2] ARM: ux500: Disable the MMCI gpio-regulator by default Lee Jones
2012-11-15 13:14 ` [PATCH 2/2] ARM: ux500: Move board specific GPIO info out to subordinate DTS files Lee Jones
2012-11-20 16:08 ` [PATCH 1/2] ARM: ux500: Disable the MMCI gpio-regulator by default Lee Jones
@ 2012-11-20 22:37 ` Linus Walleij
2 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2012-11-20 22:37 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-arm-kernel, linux-kernel, arnd, linus.walleij
On Thu, Nov 15, 2012 at 2:14 PM, Lee Jones <lee.jones@linaro.org> wrote:
> Not all supported boards will require a MMCI gpio-regulator,
> therefore it's a good idea to only enable the node when and if
> it is required. Let's disable it by default.
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Sorry for the delay.
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-11-20 22:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-15 13:14 [PATCH 1/2] ARM: ux500: Disable the MMCI gpio-regulator by default Lee Jones
2012-11-15 13:14 ` [PATCH 2/2] ARM: ux500: Move board specific GPIO info out to subordinate DTS files Lee Jones
2012-11-20 16:08 ` Lee Jones
2012-11-20 22:38 ` Linus Walleij
2012-11-20 16:08 ` [PATCH 1/2] ARM: ux500: Disable the MMCI gpio-regulator by default Lee Jones
2012-11-20 22:37 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox