From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Kees Cook <keescook@chromium.org>
Cc: Kay Sievers <kay@vrfy.org>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
ellyjones@chromium.org, Roland Eggner <edvx1@systemanalysen.net>
Subject: Re: [PATCH v2] devtmpfs: mount with noexec and nosuid
Date: Wed, 21 Nov 2012 00:32:01 +0000 [thread overview]
Message-ID: <20121121003201.24181fdf@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <CAGXu5jK5VWU8qxOAsrhSMrrdDaZVpLJWw0dQk3newvUK56rzVw@mail.gmail.com>
On Tue, 20 Nov 2012 16:18:33 -0800
Kees Cook <keescook@chromium.org> wrote:
> On Tue, Nov 20, 2012 at 4:13 PM, Kay Sievers <kay@vrfy.org> wrote:
> > On Tue, Nov 20, 2012 at 9:42 PM, Kees Cook <keescook@chromium.org> wrote:
> >> Since devtmpfs is writable, make the default noexec,nosuid as well. This
> >> protects from the case of a privileged process having an arbitrary file
> >> write flaw and an argumentless arbitrary execution (i.e. it would lack
> >> the ability to run "mount -o remount,exec,suid /dev").
> >
> > This only really applies to systems without an initramfs when the
> > kernel mounts /dev over the rootfs it has mounted; with an initramfs,
> > /dev is always mounted by user code.
> >
> > Just checking, that is the use case you are doing that for?
>
> Correct. We're using this in Chrome OS, which does not use an initramfs.
But which has a perfectly good init process of its own, so it's just fine.
If you fix your init to do the work then you can deploy it to all your
Google partners and onto existing devices in an update even with old
kernels. Far better security practise.
Alan
prev parent reply other threads:[~2012-11-21 0:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 20:42 [PATCH v2] devtmpfs: mount with noexec and nosuid Kees Cook
2012-11-20 20:54 ` Greg Kroah-Hartman
2012-11-20 21:41 ` Kees Cook
2012-11-20 21:13 ` Alan Cox
2012-11-20 21:49 ` Kees Cook
2012-11-20 23:53 ` Alan Cox
2012-11-20 23:53 ` Kees Cook
2012-11-21 0:24 ` Alan Cox
2012-11-21 0:41 ` Kees Cook
2012-11-21 1:00 ` Alan Cox
2012-11-21 0:13 ` Kay Sievers
2012-11-21 0:18 ` Kees Cook
2012-11-21 0:32 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121121003201.24181fdf@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=edvx1@systemanalysen.net \
--cc=ellyjones@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=kay@vrfy.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox