From: Dan Carpenter <dan.carpenter@oracle.com>
To: MAACHE Mehdi <mehdi.maache@gmail.com>
Cc: greg@kroah.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, tdent48227@gmail.com
Subject: Re: [PATCH] Staging: rtl8187se: bugfix in r8180_wx.c
Date: Wed, 21 Nov 2012 16:42:00 +0300 [thread overview]
Message-ID: <20121121134200.GH6186@mwanda> (raw)
In-Reply-To: <1353504042-9422-1-git-send-email-mehdi.maache@gmail.com>
On Wed, Nov 21, 2012 at 02:20:42PM +0100, MAACHE Mehdi wrote:
> This bug was introduced in de171bd6ff "Staging: rtl8187se: r8180_wx: fixed a lot of checkpatch.pl issues".
>
The change log should describe the patch so we don't have to read
the code to know what it does. Idealy it would describe the user
visible effects of the code, but neither you nor I really know what
those are.
Here is a better changelog. Please resend with this or something
similar.
---
Subject: [PATCH v2] Staging: rtl8187se: remove check for IW_ENCODE_DISABLED
The original code had a no-op stub where it checked if
IW_ENCODE_DISABLED and did nothing. Then in a cleanup patch we
accidentally turned the check on. That was: de171bd6ff "Staging:
rtl8187se: r8180_wx: fixed a lot of checkpatch.pl issues".
The check should just be removed.
---
regards,
dan carpenter
next prev parent reply other threads:[~2012-11-21 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 13:20 [PATCH] Staging: rtl8187se: bugfix in r8180_wx.c MAACHE Mehdi
2012-11-21 13:42 ` Dan Carpenter [this message]
2012-11-21 14:14 ` MAACHE Mehdi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121121134200.GH6186@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mehdi.maache@gmail.com \
--cc=tdent48227@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox