* [PATCH] Staging: rtl8187se: bugfix in r8180_wx.c
@ 2012-11-21 13:20 MAACHE Mehdi
2012-11-21 13:42 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: MAACHE Mehdi @ 2012-11-21 13:20 UTC (permalink / raw)
To: greg; +Cc: devel, linux-kernel, tdent48227, dan.carpenter, MAACHE Mehdi
This bug was introduced in de171bd6ff "Staging: rtl8187se: r8180_wx: fixed a lot of checkpatch.pl issues".
Signed-off-by: Mehdi MAACHE <mehdi.maache@gmail.com>
---
drivers/staging/rtl8187se/r8180_wx.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_wx.c b/drivers/staging/rtl8187se/r8180_wx.c
index 52f63d7..156b758 100644
--- a/drivers/staging/rtl8187se/r8180_wx.c
+++ b/drivers/staging/rtl8187se/r8180_wx.c
@@ -59,8 +59,6 @@ int r8180_wx_set_key(struct net_device *dev, struct iw_request_info *info,
if (priv->ieee80211->bHwRadioOff)
return 0;
- if (erq->flags & IW_ENCODE_DISABLED)
-
if (erq->length > 0) {
u32* tkey = (u32*) key;
priv->key0[0] = tkey[0];
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Staging: rtl8187se: bugfix in r8180_wx.c
2012-11-21 13:20 [PATCH] Staging: rtl8187se: bugfix in r8180_wx.c MAACHE Mehdi
@ 2012-11-21 13:42 ` Dan Carpenter
2012-11-21 14:14 ` MAACHE Mehdi
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2012-11-21 13:42 UTC (permalink / raw)
To: MAACHE Mehdi; +Cc: greg, devel, linux-kernel, tdent48227
On Wed, Nov 21, 2012 at 02:20:42PM +0100, MAACHE Mehdi wrote:
> This bug was introduced in de171bd6ff "Staging: rtl8187se: r8180_wx: fixed a lot of checkpatch.pl issues".
>
The change log should describe the patch so we don't have to read
the code to know what it does. Idealy it would describe the user
visible effects of the code, but neither you nor I really know what
those are.
Here is a better changelog. Please resend with this or something
similar.
---
Subject: [PATCH v2] Staging: rtl8187se: remove check for IW_ENCODE_DISABLED
The original code had a no-op stub where it checked if
IW_ENCODE_DISABLED and did nothing. Then in a cleanup patch we
accidentally turned the check on. That was: de171bd6ff "Staging:
rtl8187se: r8180_wx: fixed a lot of checkpatch.pl issues".
The check should just be removed.
---
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: rtl8187se: bugfix in r8180_wx.c
2012-11-21 13:42 ` Dan Carpenter
@ 2012-11-21 14:14 ` MAACHE Mehdi
0 siblings, 0 replies; 3+ messages in thread
From: MAACHE Mehdi @ 2012-11-21 14:14 UTC (permalink / raw)
To: Dan Carpenter; +Cc: greg, devel, linux-kernel, tdent48227
Le 21/11/2012 14:42, Dan Carpenter a écrit :
>
> Here is a better changelog. Please resend with this or something
> similar.
>
> ---
> Subject: [PATCH v2] Staging: rtl8187se: remove check for IW_ENCODE_DISABLED
>
> The original code had a no-op stub where it checked if
> IW_ENCODE_DISABLED and did nothing. Then in a cleanup patch we
> accidentally turned the check on. That was: de171bd6ff "Staging:
> rtl8187se: r8180_wx: fixed a lot of checkpatch.pl issues".
>
> The check should just be removed.
> ---
>
> regards,
> dan carpenter
>
Thanks again. I wiil do this and next time, I will try a better description.
regards,
maache mehdi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-21 14:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-21 13:20 [PATCH] Staging: rtl8187se: bugfix in r8180_wx.c MAACHE Mehdi
2012-11-21 13:42 ` Dan Carpenter
2012-11-21 14:14 ` MAACHE Mehdi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox