[PATCH] Staging: rtl8187se: bugfix in r8180_wx.c

[PATCH] Staging: rtl8187se: bugfix in r8180_wx.c

[MAACHE Mehdi]

This bug was introduced in de171bd6ff "Staging: rtl8187se: r8180_wx: fixed a lot of checkpatch.pl issues".

Signed-off-by: Mehdi MAACHE <mehdi.maache@gmail.com>
---
 drivers/staging/rtl8187se/r8180_wx.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8187se/r8180_wx.c b/drivers/staging/rtl8187se/r8180_wx.c
index 52f63d7..156b758 100644
--- a/drivers/staging/rtl8187se/r8180_wx.c
+++ b/drivers/staging/rtl8187se/r8180_wx.c
@@ -59,8 +59,6 @@ int r8180_wx_set_key(struct net_device *dev, struct iw_request_info *info,
 	if (priv->ieee80211->bHwRadioOff)
 		return 0;
 
-	if (erq->flags & IW_ENCODE_DISABLED)
-
 	if (erq->length > 0) {
 		u32* tkey = (u32*) key;
 		priv->key0[0] = tkey[0];
-- 
1.7.1

Re: [PATCH] Staging: rtl8187se: bugfix in r8180_wx.c

[Dan Carpenter]

On Wed, Nov 21, 2012 at 02:20:42PM +0100, MAACHE Mehdi wrote:
> This bug was introduced in de171bd6ff "Staging: rtl8187se: r8180_wx: fixed a lot of checkpatch.pl issues".
> 

The change log should describe the patch so we don't have to read
the code to know what it does.  Idealy it would describe the user
visible effects of the code, but neither you nor I really know what
those are.

Here is a better changelog.  Please resend with this or something
similar.

---
Subject: [PATCH v2] Staging: rtl8187se: remove check for IW_ENCODE_DISABLED

The original code had a no-op stub where it checked if
IW_ENCODE_DISABLED and did nothing.  Then in a cleanup patch we
accidentally turned the check on.  That was: de171bd6ff "Staging:
rtl8187se: r8180_wx: fixed a lot of checkpatch.pl issues".

The check should just be removed.
---

regards,
dan carpenter

Re: [PATCH] Staging: rtl8187se: bugfix in r8180_wx.c

[MAACHE Mehdi]

Le 21/11/2012 14:42, Dan Carpenter a écrit :

> 
> Here is a better changelog.  Please resend with this or something
> similar.
> 
> ---
> Subject: [PATCH v2] Staging: rtl8187se: remove check for IW_ENCODE_DISABLED
> 
> The original code had a no-op stub where it checked if
> IW_ENCODE_DISABLED and did nothing.  Then in a cleanup patch we
> accidentally turned the check on.  That was: de171bd6ff "Staging:
> rtl8187se: r8180_wx: fixed a lot of checkpatch.pl issues".
> 
> The check should just be removed.
> ---
> 
> regards,
> dan carpenter
> 


Thanks again. I wiil do this and next time, I will try a better description.

regards,

maache mehdi