From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Lothar Waßmann" <LW@KARO-electronics.de>
Cc: alsa-devel@alsa-project.org, Shawn Guo <shawn.guo@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [BUGFIX PATCH] ASoC: fsl: fix miscompilation of snd-soc-imx-pcm
Date: Fri, 23 Nov 2012 11:05:18 +0900 [thread overview]
Message-ID: <20121123020517.GJ4385@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1353587470-11994-1-git-send-email-LW@KARO-electronics.de>
[-- Attachment #1: Type: text/plain, Size: 673 bytes --]
On Thu, Nov 22, 2012 at 01:31:06PM +0100, Lothar Waßmann wrote:
> obj-$(CONFIG_SND_SOC_IMX_PCM) += snd-soc-imx-pcm.o
> snd-soc-imx-pcm-y := imx-pcm.o
> -snd-soc-imx-pcm-$(CONFIG_SND_SOC_IMX_PCM_FIQ) += imx-pcm-fiq.o
> -snd-soc-imx-pcm-$(CONFIG_SND_SOC_IMX_PCM_DMA) += imx-pcm-dma.o
> +ifneq ($(CONFIG_SND_SOC_IMX_PCM_FIQ),)
> + snd-soc-imx-pcm-objs += imx-pcm-fiq.o
> +endif
> +ifneq ($(CONFIG_SND_SOC_IMX_PCM_DMA),)
> + snd-soc-imx-pcm-objs += imx-pcm-dma.o
> +endif
What is the actual bug here? This fix doesn't look obviously right, and
if we do need to move to -objs for some reason then the block ought to
be in the -objs section of the Makefile.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-23 2:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 12:31 [BUGFIX PATCH] ASoC: fsl: fix miscompilation of snd-soc-imx-pcm Lothar Waßmann
2012-11-22 12:31 ` [PATCH] ASoC: imx: add MODULE_LICENSE("GPL") Lothar Waßmann
2012-11-23 14:40 ` Mark Brown
2012-11-22 12:31 ` [BUGFIX PATCH] ASoC: imx-sgtl5000: prevent module from being unloaded when in use Lothar Waßmann
2012-11-23 14:42 ` Mark Brown
2012-11-22 12:31 ` [PATCH] ASoC: mxs-saif: export mxs_saif_put_mclk,mxs_saif_get_mclk Lothar Waßmann
2012-11-23 2:06 ` Mark Brown
2012-11-23 7:21 ` Lothar Waßmann
2012-11-23 14:45 ` Mark Brown
2012-11-26 8:49 ` Lothar Waßmann
2012-11-22 12:31 ` [PATCH] ASoC: dmaengine_pcm: set MODULE_LICENSE Lothar Waßmann
2012-11-23 2:05 ` Mark Brown [this message]
2012-11-23 6:59 ` [BUGFIX PATCH] ASoC: fsl: fix miscompilation of snd-soc-imx-pcm Lothar Waßmann
2012-11-23 8:13 ` Mark Brown
2012-11-23 9:12 ` [PATCH v2] " Lothar Waßmann
2012-11-23 10:08 ` Mark Brown
2012-11-23 10:21 ` Lothar Waßmann
2012-11-23 11:47 ` Mark Brown
2012-11-26 8:50 ` [PATCH v3] " Lothar Waßmann
2012-11-27 19:36 ` [PATCH v2] " Mark Brown
2012-11-27 19:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121123020517.GJ4385@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=LW@KARO-electronics.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox