* [PATCH] mfd: wm5102: Correct default for LDO1_CONTROL_2
@ 2012-11-28 18:47 Mark Brown
2012-11-29 11:18 ` Charles Keepax
2012-11-30 10:20 ` Samuel Ortiz
0 siblings, 2 replies; 5+ messages in thread
From: Mark Brown @ 2012-11-28 18:47 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: linux-kernel, patches, Mark Brown
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/mfd/wm5102-tables.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/wm5102-tables.c b/drivers/mfd/wm5102-tables.c
index 50bbe15..065ffd3 100644
--- a/drivers/mfd/wm5102-tables.c
+++ b/drivers/mfd/wm5102-tables.c
@@ -307,6 +307,7 @@ static const struct reg_default wm5102_reg_default[] = {
{ 0x000001AA, 0x0004 }, /* R426 - FLL2 GPIO Clock */
{ 0x00000200, 0x0006 }, /* R512 - Mic Charge Pump 1 */
{ 0x00000210, 0x00D4 }, /* R528 - LDO1 Control 1 */
+ { 0x00000212, 0x0001 }, /* R530 - LDO1 Control 2 */
{ 0x00000213, 0x0344 }, /* R531 - LDO2 Control 1 */
{ 0x00000218, 0x01A6 }, /* R536 - Mic Bias Ctrl 1 */
{ 0x00000219, 0x01A6 }, /* R537 - Mic Bias Ctrl 2 */
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] mfd: wm5102: Correct default for LDO1_CONTROL_2
2012-11-28 18:47 [PATCH] mfd: wm5102: Correct default for LDO1_CONTROL_2 Mark Brown
@ 2012-11-29 11:18 ` Charles Keepax
2012-11-29 11:40 ` Mark Brown
2012-11-30 10:20 ` Samuel Ortiz
1 sibling, 1 reply; 5+ messages in thread
From: Charles Keepax @ 2012-11-29 11:18 UTC (permalink / raw)
To: Mark Brown; +Cc: Samuel Ortiz, patches, linux-kernel
On Wed, Nov 28, 2012 at 06:47:28PM +0000, Mark Brown wrote:
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/wm5102-tables.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/wm5102-tables.c b/drivers/mfd/wm5102-tables.c
> index 50bbe15..065ffd3 100644
> --- a/drivers/mfd/wm5102-tables.c
> +++ b/drivers/mfd/wm5102-tables.c
> @@ -307,6 +307,7 @@ static const struct reg_default wm5102_reg_default[] = {
> { 0x000001AA, 0x0004 }, /* R426 - FLL2 GPIO Clock */
> { 0x00000200, 0x0006 }, /* R512 - Mic Charge Pump 1 */
> { 0x00000210, 0x00D4 }, /* R528 - LDO1 Control 1 */
> + { 0x00000212, 0x0001 }, /* R530 - LDO1 Control 2 */
The default for this register is changed in the register patch to
zero should we not leave this setting at zero to match?
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mfd: wm5102: Correct default for LDO1_CONTROL_2
2012-11-29 11:18 ` Charles Keepax
@ 2012-11-29 11:40 ` Mark Brown
0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2012-11-29 11:40 UTC (permalink / raw)
To: Charles Keepax; +Cc: Samuel Ortiz, patches, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 438 bytes --]
On Thu, Nov 29, 2012 at 11:18:27AM +0000, Charles Keepax wrote:
> On Wed, Nov 28, 2012 at 06:47:28PM +0000, Mark Brown wrote:
> > + { 0x00000212, 0x0001 }, /* R530 - LDO1 Control 2 */
> The default for this register is changed in the register patch to
> zero should we not leave this setting at zero to match?
The patch file is different for newer revs, I suspect we will be
changing the patch for rev A to follow suit.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mfd: wm5102: Correct default for LDO1_CONTROL_2
2012-11-28 18:47 [PATCH] mfd: wm5102: Correct default for LDO1_CONTROL_2 Mark Brown
2012-11-29 11:18 ` Charles Keepax
@ 2012-11-30 10:20 ` Samuel Ortiz
1 sibling, 0 replies; 5+ messages in thread
From: Samuel Ortiz @ 2012-11-30 10:20 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-kernel, patches
Hi Mark,
On Wed, Nov 28, 2012 at 06:47:28PM +0000, Mark Brown wrote:
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/wm5102-tables.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] mfd: wm5102: Correct default for LDO1_CONTROL_2
@ 2012-11-28 18:47 Mark Brown
0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2012-11-28 18:47 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: linux-kernel, patches, Mark Brown
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/mfd/wm5102-tables.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/wm5102-tables.c b/drivers/mfd/wm5102-tables.c
index 50bbe15..065ffd3 100644
--- a/drivers/mfd/wm5102-tables.c
+++ b/drivers/mfd/wm5102-tables.c
@@ -307,6 +307,7 @@ static const struct reg_default wm5102_reg_default[] = {
{ 0x000001AA, 0x0004 }, /* R426 - FLL2 GPIO Clock */
{ 0x00000200, 0x0006 }, /* R512 - Mic Charge Pump 1 */
{ 0x00000210, 0x00D4 }, /* R528 - LDO1 Control 1 */
+ { 0x00000212, 0x0001 }, /* R530 - LDO1 Control 2 */
{ 0x00000213, 0x0344 }, /* R531 - LDO2 Control 1 */
{ 0x00000218, 0x01A6 }, /* R536 - Mic Bias Ctrl 1 */
{ 0x00000219, 0x01A6 }, /* R537 - Mic Bias Ctrl 2 */
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-11-30 10:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-28 18:47 [PATCH] mfd: wm5102: Correct default for LDO1_CONTROL_2 Mark Brown
2012-11-29 11:18 ` Charles Keepax
2012-11-29 11:40 ` Mark Brown
2012-11-30 10:20 ` Samuel Ortiz
-- strict thread matches above, loose matches on Subject: below --
2012-11-28 18:47 Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox