From: Jean Delvare <khali@linux-fr.org>
To: David Howells <dhowells@redhat.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86: Provide guards in uapi/asm/hw_breakpoint.h to prevent deletion by patch
Date: Wed, 19 Dec 2012 09:46:45 +0100 [thread overview]
Message-ID: <20121219094645.05a8670a@endymion.delvare> (raw)
In-Reply-To: <20121217144924.7769.69501.stgit@warthog.procyon.org.uk>
On Mon, 17 Dec 2012 14:49:25 +0000, David Howells wrote:
> Provide reinclusion guards in the empty uapi/asm/hw_breakpoint.h to make sure
> that the patch program doesn't delete it.
>
> However, should some part of asm/hw_breakpoint.h actually be exported here,
> or, possibly, should the entire uapi file be removed? In v3.6, though the
> file was marked for export to userspace, it had nothing outside of __KERNEL__.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
> cc: Jean Delvare <khali@linux-fr.org>
> ---
>
> arch/x86/include/uapi/asm/hw_breakpoint.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/x86/include/uapi/asm/hw_breakpoint.h b/arch/x86/include/uapi/asm/hw_breakpoint.h
> index e69de29..895596b 100644
> --- a/arch/x86/include/uapi/asm/hw_breakpoint.h
> +++ b/arch/x86/include/uapi/asm/hw_breakpoint.h
> @@ -0,0 +1,4 @@
> +#ifndef _UAPI_I386_HW_BREAKPOINT_H
> +#define _UAPI_I386_HW_BREAKPOINT_H
> +
> +#endif /* _UAPI_I386_HW_BREAKPOINT_H */
>
Reviewed-by: Jean Delvare <khali@linux-fr.org>
--
Jean Delvare
prev parent reply other threads:[~2012-12-19 8:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 14:49 [PATCH 1/2] x86: Provide guards in uapi/asm/hw_breakpoint.h to prevent deletion by patch David Howells
2012-12-17 14:49 ` [PATCH 2/2] x86: Provide guards in uapi/asm/setup.h " David Howells
2012-12-19 8:47 ` Jean Delvare
2012-12-19 8:46 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121219094645.05a8670a@endymion.delvare \
--to=khali@linux-fr.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox