Re: [PATCH 2/2] x86: Provide guards in uapi/asm/setup.h to prevent deletion by patch

[Jean Delvare <khali@linux-fr.org>]

On Mon, 17 Dec 2012 14:49:32 +0000, David Howells wrote:
> Provide reinclusion guards in the empty uapi/asm/setup.h to make sure that the
> patch program doesn't delete it.
> 
> However, should some part of asm/hw_setup.h actually be exported here, or,
> possibly, should the entire uapi file be removed?  In v3.6, though the file
> was marked for export to userspace, it had nothing outside of __KERNEL__.
> 
> Signed-off-by: David Howells <dhowells@redhat.com>
> cc: Jean Delvare <khali@linux-fr.org>
> ---
> 
>  arch/x86/include/uapi/asm/setup.h |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/x86/include/uapi/asm/setup.h b/arch/x86/include/uapi/asm/setup.h
> index e69de29..96a4d53 100644
> --- a/arch/x86/include/uapi/asm/setup.h
> +++ b/arch/x86/include/uapi/asm/setup.h
> @@ -0,0 +1,4 @@
> +#ifndef _UAPI_ASM_X86_SETUP_H
> +#define _UAPI_ASM_X86_SETUP_H
> +
> +#endif /* _UAPI_ASM_X86_SETUP_H */
> 

Reviewed-by: Jean Delvare <khali@linux-fr.org>

-- 
Jean Delvare