From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Xiao Jin <jin.xiao@intel.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
mingo@elte.hu, a.p.zijlstra@chello.nl, rusty@rustcorp.com.au,
william.douglas@intel.com, sboyd@codeaurora.org,
gregkh@linuxfoundation.org, jslaby@suse.cz,
vincentx.pillet@intel.com
Subject: Re: [PATCH] n_gsm.c: add tx_lock in gsm_send
Date: Thu, 20 Dec 2012 11:44:11 +0000 [thread overview]
Message-ID: <20121220114411.4dcc81bb@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <1355963920.9600.99.camel@xiaojin>
On Thu, 20 Dec 2012 08:38:40 +0800
Xiao Jin <jin.xiao@intel.com> wrote:
> From: xiaojin <jin.xiao@intel.com>
> Date: Wed, 19 Dec 2012 11:53:43 +0800
> Subject: [PATCH] n_gsm.c: add tx_lock in gsm_send
>
> All the call to gsm->output should be in the tx_lock,
> that could avoid potential race from MUX level. But
> we have no tx_lock in gsm_send.
>
> This patch is to add tx_lock in gsm_send.
gsm->output calls the transmit method of the underlying tty driver. We
can't do that with interrupts off as some drivers expect to be able to
sleep in their output paths.
Alan
next prev parent reply other threads:[~2012-12-20 11:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 0:38 [PATCH] n_gsm.c: add tx_lock in gsm_send Xiao Jin
2012-12-20 11:44 ` Alan Cox [this message]
2012-12-20 12:13 ` Xiao, Jin
2012-12-20 13:06 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2012-12-19 5:16 Xiao Jin
2012-12-20 13:08 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121220114411.4dcc81bb@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jin.xiao@intel.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=sboyd@codeaurora.org \
--cc=vincentx.pillet@intel.com \
--cc=william.douglas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox