From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Xiao, Jin" <jin.xiao@intel.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mingo@elte.hu" <mingo@elte.hu>,
"a.p.zijlstra@chello.nl" <a.p.zijlstra@chello.nl>,
"rusty@rustcorp.com.au" <rusty@rustcorp.com.au>,
"Douglas, William" <william.douglas@intel.com>,
"sboyd@codeaurora.org" <sboyd@codeaurora.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jslaby@suse.cz" <jslaby@suse.cz>,
"Pillet, VincentX" <vincentx.pillet@intel.com>
Subject: Re: [PATCH] n_gsm.c: add tx_lock in gsm_send
Date: Thu, 20 Dec 2012 13:06:26 +0000 [thread overview]
Message-ID: <20121220130626.6b4aea39@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <375E373B4157DC49B89CEAE588F836F50FE455C5@SHSMSX102.ccr.corp.intel.com>
On Thu, 20 Dec 2012 12:13:07 +0000
"Xiao, Jin" <jin.xiao@intel.com> wrote:
> Alan,
>
> Thanks. But the comment makes me confused. As we see, gsm->output is called by gsm_data_kick too, and it's in the tx_lock...
That would be a bug too or I guess we could finally give in on trying to
keep tty write paths not using spin_lock_irq and fix any oddments that
blow up. That might actually be the right thing to do as its caused
problems in other places too, and the USB tty drivers are now well
behaved.
Your patch doesn't make it any worse however so I agree it might as well
go in.
Alan
next prev parent reply other threads:[~2012-12-20 13:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 0:38 [PATCH] n_gsm.c: add tx_lock in gsm_send Xiao Jin
2012-12-20 11:44 ` Alan Cox
2012-12-20 12:13 ` Xiao, Jin
2012-12-20 13:06 ` Alan Cox [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-12-19 5:16 Xiao Jin
2012-12-20 13:08 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121220130626.6b4aea39@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jin.xiao@intel.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=sboyd@codeaurora.org \
--cc=vincentx.pillet@intel.com \
--cc=william.douglas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox