[PATCH] get_maintainer.pl: Find maintainers for removed files

[PATCH] get_maintainer.pl: Find maintainers for removed files

[Geert Uytterhoeven]

For removed files, get_maintainer.pl doesn't find any maintainers (besides
the default linux-kernel@vger.kernel.org), as it only looks at the "+++"
lines, which are "/dev/null" for removals.
Fix this by extending the parsing to the "---" lines.

E.g. for the two line test patch below the real score maintainers will now
be found:

    --- a/arch/score/include/asm/dma-mapping.h
    +++ /dev/null

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 scripts/get_maintainer.pl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 8b673dd..18d4ab5 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -433,7 +433,7 @@ foreach my $file (@ARGV) {
 
 	while (<$patch>) {
 	    my $patch_line = $_;
-	    if (m/^\+\+\+\s+(\S+)/) {
+	    if (m/^\+\+\+\s+(\S+)/ or m/^---\s+(\S+)/) {
 		my $filename = $1;
 		$filename =~ s@^[^/]*/@@;
 		$filename =~ s@\n@@;
-- 
1.7.0.4

Re: [PATCH] get_maintainer.pl: Find maintainers for removed files

[Al Viro]

On Fri, Dec 28, 2012 at 08:27:50PM +0100, Geert Uytterhoeven wrote:
> For removed files, get_maintainer.pl doesn't find any maintainers (besides
> the default linux-kernel@vger.kernel.org), as it only looks at the "+++"
> lines, which are "/dev/null" for removals.
> Fix this by extending the parsing to the "---" lines.
> 
> E.g. for the two line test patch below the real score maintainers will now
> be found:

*snort*

I'm afraid that finding anybody matching that description would reqiure
a functioning time machine.  AFAICT, arch/score has been orphaned for
several years.

Re: [PATCH] get_maintainer.pl: Find maintainers for removed files

[Geert Uytterhoeven]

On Fri, Dec 28, 2012 at 8:36 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Fri, Dec 28, 2012 at 08:27:50PM +0100, Geert Uytterhoeven wrote:
>> For removed files, get_maintainer.pl doesn't find any maintainers (besides
>> the default linux-kernel@vger.kernel.org), as it only looks at the "+++"
>> lines, which are "/dev/null" for removals.
>> Fix this by extending the parsing to the "---" lines.
>>
>> E.g. for the two line test patch below the real score maintainers will now
>> be found:
>
> *snort*
>
> I'm afraid that finding anybody matching that description would reqiure
> a functioning time machine.  AFAICT, arch/score has been orphaned for
> several years.

;-)

Sorry, I meant the maintainers listed in MAINTAINERS.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] get_maintainer.pl: Find maintainers for removed files

[Joe Perches]

On Fri, 2012-12-28 at 20:27 +0100, Geert Uytterhoeven wrote:
> For removed files, get_maintainer.pl doesn't find any maintainers (besides
> the default linux-kernel@vger.kernel.org), as it only looks at the "+++"
> lines, which are "/dev/null" for removals.
> Fix this by extending the parsing to the "---" lines.
[]
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
[]
> @@ -433,7 +433,7 @@ foreach my $file (@ARGV) {
>  
>  	while (<$patch>) {
>  	    my $patch_line = $_;
> -	    if (m/^\+\+\+\s+(\S+)/) {
> +	    if (m/^\+\+\+\s+(\S+)/ or m/^---\s+(\S+)/) {
>  		my $filename = $1;
>  		$filename =~ s@^[^/]*/@@;
>  		$filename =~ s@\n@@;

OK, but this would now match any keyword in a deleted filename.