From: Hans Verkuil <hansverk@cisco.com>
To: Federico Vaga <federico.vaga@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Giancarlo Asnaghi <giancarlo.asnaghi@st.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/2] sta2x11_vip: convert to videobuf2, control framework, file handler
Date: Wed, 6 Feb 2013 10:49:10 +0100 [thread overview]
Message-ID: <201302061049.10879.hansverk@cisco.com> (raw)
In-Reply-To: <1360089277-27898-1-git-send-email-federico.vaga@gmail.com>
Hi Federico,
OK, I'm going to give this my Acked-by, but I really wish you would have split
this up into smaller changes. It's hard to review since you have made so many
changes in this one patch. Even though I'm giving my ack, Mauro might decide
against it, so if you have time to spread out the changes in multiple patches,
then please do so.
So, given the fact that this changes just a single driver not commonly used in
existing deployments, assuming that you have tested the changes (you did that,
right? Just checking...), that these are really useful improvements, and that
I reviewed the code (as well as I could) and didn't see any problems, I'm
giving my ack anyway:
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Regards,
Hans
next prev parent reply other threads:[~2013-02-06 9:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 14:07 [PATCH v6 1/2] sta2x11_vip: convert to videobuf2, control framework, file handler Federico Vaga
2013-01-23 14:07 ` [PATCH v6 2/2] adv7180: remove {query/g_/s_}ctrl Federico Vaga
2013-02-04 10:57 ` [PATCH v6 1/2] sta2x11_vip: convert to videobuf2, control framework, file handler Hans Verkuil
2013-02-05 18:34 ` Federico Vaga
2013-02-06 9:49 ` Hans Verkuil [this message]
2013-02-06 14:26 ` Federico Vaga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201302061049.10879.hansverk@cisco.com \
--to=hansverk@cisco.com \
--cc=federico.vaga@gmail.com \
--cc=giancarlo.asnaghi@st.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@infradead.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox