From: Jan Kara <jack@suse.cz>
To: David Rientjes <rientjes@google.com>
Cc: Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
jslaby@suse.cz, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v2] printk: Avoid softlockups in console_unlock()
Date: Wed, 6 Feb 2013 20:51:35 +0100 [thread overview]
Message-ID: <20130206195135.GA12117@quack.suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.02.1302061125230.29136@chino.kir.corp.google.com>
On Wed 06-02-13 11:26:46, David Rientjes wrote:
> On Wed, 6 Feb 2013, Jan Kara wrote:
>
> > On Wed 06-02-13 09:58:48, David Rientjes wrote:
> > > On Wed, 6 Feb 2013, Jan Kara wrote:
> > >
> > > > Yes, I noticed that thread just yesterday and also though that using
> > > > similar trick might be viable. I'll experiment if we could use the same
> > > > method for handling lockup problems I hit. Steven seems to have already
> > > > tweaked PRINTK_PENDING stuff to be usable more easily...
> > > >
> > >
> > > Are these new build failures in linux-next coming from this patch?
> > >
> > > kernel/printk.c: In function 'console_unlock':
> > > kernel/printk.c:2156:18: error: 'printk_work' undeclared (first use in this function)
> > > kernel/printk.c:2156:18: note: each undeclared identifier is reported only once for each function it appears in
> > > kernel/printk.c: At top level:
> > > kernel/printk.c:2167:13: warning: 'printk_worker' defined but not used [-Wunused-function]
> > Yes, I already sent a patch to fix these (attached if you need it).
> > Thanks for notice.
> >
>
> I don't see your attached
> printk-Fixup-compilation-with-CONFIG_PRINTK.patch in -mm nor do I see it
> on any mailing list. Regardless,
Yeah, it was a private mail from kernel compilation testing guys with
Andrew in CC.
> Acked-by: David Rientjes <rientjes@google.com>
Thanks.
> for wherever Andrew has this stashed away. Thanks.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2013-02-06 19:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 22:17 [PATCH v2] printk: Avoid softlockups in console_unlock() Jan Kara
2013-02-05 20:38 ` Andrew Morton
2013-02-05 22:56 ` Frederic Weisbecker
2013-02-06 0:42 ` Steven Rostedt
2013-02-06 14:23 ` Jan Kara
2013-02-06 17:58 ` David Rientjes
2013-02-06 18:52 ` Jan Kara
2013-02-06 19:26 ` David Rientjes
2013-02-06 19:51 ` Jan Kara [this message]
2013-02-06 20:19 ` Hugh Dickins
2013-02-06 21:29 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130206195135.GA12117@quack.suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox