From: Magnus Damm <magnus.damm@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: kuninori.morimoto.gx@renesas.com, linux-sh@vger.kernel.org,
benh@kernel.crashing.org, grant.likely@secretlab.ca,
horms@verge.net.au, Magnus Damm <magnus.damm@gmail.com>,
tglx@linutronix.de
Subject: [PATCH 03/05] irqchip: intc-irqpin: Add force comments
Date: Tue, 26 Feb 2013 20:59:04 +0900 [thread overview]
Message-ID: <20130226115904.5630.11666.sendpatchset@w520> (raw)
In-Reply-To: <20130226115834.5630.45471.sendpatchset@w520>
From: Magnus Damm <damm@opensource.se>
Add comments to describe the special case for
"force" versions of enable and disable functions.
Signed-off-by: Magnus Damm <damm@opensource.se>
---
Thanks to Thomas Gleixner for this suggestion.
drivers/irqchip/irq-renesas-intc-irqpin.c | 9 +++++++++
1 file changed, 9 insertions(+)
--- 0006/drivers/irqchip/irq-renesas-intc-irqpin.c
+++ work/drivers/irqchip/irq-renesas-intc-irqpin.c 2013-02-26 19:36:33.000000000 +0900
@@ -199,6 +199,11 @@ static void intc_irqpin_irq_enable_force
int irq = p->irq[irqd_to_hwirq(d)].requested_irq;
intc_irqpin_irq_enable(d);
+
+ /* enable interrupt through parent interrupt controller,
+ * assumes non-shared interrupt with 1:1 mapping
+ * needed for busted IRQs on some SoCs like sh73a0
+ */
irq_get_chip(irq)->irq_unmask(irq_get_irq_data(irq));
}
@@ -207,6 +212,10 @@ static void intc_irqpin_irq_disable_forc
struct intc_irqpin_priv *p = irq_data_get_irq_chip_data(d);
int irq = p->irq[irqd_to_hwirq(d)].requested_irq;
+ /* disable interrupt through parent interrupt controller,
+ * assumes non-shared interrupt with 1:1 mapping
+ * needed for busted IRQs on some SoCs like sh73a0
+ */
irq_get_chip(irq)->irq_mask(irq_get_irq_data(irq));
intc_irqpin_irq_disable(d);
}
next prev parent reply other threads:[~2013-02-26 11:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 11:58 [PATCH 00/05] irqchip: Renesas INTC External IRQ pin v2 update Magnus Damm
2013-02-26 11:58 ` [PATCH 01/05] irqchip: intc-irqpin: Whitespace fixes Magnus Damm
2013-02-26 11:58 ` [PATCH 02/05] irqchip: intc-irqpin: Cache mapped IRQ Magnus Damm
2013-02-26 11:59 ` Magnus Damm [this message]
2013-02-26 11:59 ` [PATCH 04/05] irqchip: intc-irqpin: Make use of devm functions Magnus Damm
2013-02-26 11:59 ` [PATCH 05/05] irqchip: intc-irqpin: GPL header for platform data Magnus Damm
2013-02-26 12:14 ` [PATCH 00/05] irqchip: Renesas INTC External IRQ pin v2 update Simon Horman
2013-02-26 17:47 ` Thomas Gleixner
2013-03-01 9:41 ` Simon Horman
2013-03-01 15:03 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130226115904.5630.11666.sendpatchset@w520 \
--to=magnus.damm@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=grant.likely@secretlab.ca \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox