Re: [PATCH 1/1] i2c: iSMT SMBus patch for Intel Avoton DeviceIDs

Re: [PATCH 1/1] i2c: iSMT SMBus patch for Intel Avoton DeviceIDs

[Neil Horman]

On Thu, Feb 21, 2013 at 02:30:43PM -0800, Seth Heasley wrote:
> This patch adds the iSMT SMBus Controller DeviceIDs for the Intel Avoton SOC.
> 
> Signed-off-by: Seth Heasley <seth.heasley@intel.com>
Is there a part number (I.e. S1200) that we can use in the name, rather than the
project code name?  That would seem to be more in keeping with the previous
naming scheeme directly above it
Neil

RE: [PATCH 1/1] i2c: iSMT SMBus patch for Intel Avoton DeviceIDs

[Heasley, Seth]

Hi Neil,

>> This patch adds the iSMT SMBus Controller DeviceIDs for the Intel Avoton
>SOC.
>>
>> Signed-off-by: Seth Heasley <seth.heasley@intel.com>
>Is there a part number (I.e. S1200) that we can use in the name, rather than
>the project code name?  That would seem to be more in keeping with the
>previous naming scheeme directly above it Neil

The difference here is that the S1200 name is already publicly released, whereas the naming for Avoton hasn't been announced.  

Regards,
-Seth

[PATCH 1/1] i2c: iSMT SMBus patch for Intel Avoton DeviceIDs

[Seth Heasley]

This patch adds the iSMT SMBus Controller DeviceIDs for the Intel Avoton SOC.

Signed-off-by: Seth Heasley <seth.heasley@intel.com>
---
 drivers/i2c/busses/i2c-ismt.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
index 3f7a9cb..45bccf1 100644
--- a/drivers/i2c/busses/i2c-ismt.c
+++ b/drivers/i2c/busses/i2c-ismt.c
@@ -80,6 +80,7 @@
 /* PCI DIDs for the Intel SMBus Message Transport (SMT) Devices */
 #define PCI_DEVICE_ID_INTEL_S1200_SMT0	0x0c59
 #define PCI_DEVICE_ID_INTEL_S1200_SMT1	0x0c5a
+#define PCI_DEVICE_ID_INTEL_AVOTON_SMT	0x1f15
 
 #define ISMT_DESC_ENTRIES	32	/* number of descriptor entries */
 #define ISMT_MAX_RETRIES	3	/* number of SMBus retries to attempt */
@@ -185,6 +186,7 @@ struct ismt_priv {
 static const DEFINE_PCI_DEVICE_TABLE(ismt_ids) = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_S1200_SMT0) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_S1200_SMT1) },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_AVOTON_SMT) },
 	{ 0, }
 };
 
-- 
1.7.4.4

Re: [PATCH 1/1] i2c: iSMT SMBus patch for Intel Avoton DeviceIDs

[Neil Horman]

On Thu, Feb 21, 2013 at 10:19:48PM +0000, Heasley, Seth wrote:
> Hi Neil,
> 
> >> This patch adds the iSMT SMBus Controller DeviceIDs for the Intel Avoton
> >SOC.
> >>
> >> Signed-off-by: Seth Heasley <seth.heasley@intel.com>
> >Is there a part number (I.e. S1200) that we can use in the name, rather than
> >the project code name?  That would seem to be more in keeping with the
> >previous naming scheeme directly above it Neil
> 
> The difference here is that the S1200 name is already publicly released, whereas the naming for Avoton hasn't been announced.  
> 
Do you know when the announcement will be?  Is it sufficiently soon that we can
just wait for it?

Neil

> Regards,
> -Seth
> 

RE: [PATCH 1/1] i2c: iSMT SMBus patch for Intel Avoton DeviceIDs

[Heasley, Seth]

>> The difference here is that the S1200 name is already publicly released,
>whereas the naming for Avoton hasn't been announced.
>>
>Do you know when the announcement will be?  Is it sufficiently soon that we
>can just wait for it?

I don't, and actually couldn't tell you if I did.  The codename usage is consistent with how we deal with all products since the patches have to go in well in advance of product launch.

-Seth

Re: [PATCH 1/1] i2c: iSMT SMBus patch for Intel Avoton DeviceIDs

[Neil Horman]

On Tue, Feb 26, 2013 at 02:08:35AM +0000, Heasley, Seth wrote:
> >> The difference here is that the S1200 name is already publicly released,
> >whereas the naming for Avoton hasn't been announced.
> >>
> >Do you know when the announcement will be?  Is it sufficiently soon that we
> >can just wait for it?
> 
> I don't, and actually couldn't tell you if I did.  The codename usage is consistent with how we deal with all products since the patches have to go in well in advance of product launch.
> 
Meh, ok, I guess we cal always fix it up when the product has an actual name

Acked-by: Neil Horman <nhorman@tuxdriver.com>

> -Seth
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

Re: [PATCH 1/1] i2c: iSMT SMBus patch for Intel Avoton DeviceIDs

[Wolfram Sang]

On Thu, Feb 21, 2013 at 02:30:43PM -0800, Seth Heasley wrote:
> This patch adds the iSMT SMBus Controller DeviceIDs for the Intel Avoton SOC.
> 
> Signed-off-by: Seth Heasley <seth.heasley@intel.com>

Applied to for-current, thanks!