* [PATCH] drivers: mfd: sec-core: Remove explicit call to mfd_remove_devices
@ 2013-05-15 15:00 Leon Romanovsky
2013-05-16 22:13 ` Samuel Ortiz
0 siblings, 1 reply; 2+ messages in thread
From: Leon Romanovsky @ 2013-05-15 15:00 UTC (permalink / raw)
To: sbkim73, sameo; +Cc: linux-kernel, Leon Romanovsky
In case mfd_add_devices will fail, it will call to mfd_remove_devices
by itself and return non-zero value.
Signed-off-by: Leon Romanovsky <leon@leon.nu>
---
drivers/mfd/sec-core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
index 5b740a3..c93ed3d 100644
--- a/drivers/mfd/sec-core.c
+++ b/drivers/mfd/sec-core.c
@@ -230,13 +230,12 @@ static int sec_pmic_probe(struct i2c_client *i2c,
BUG();
}
- if (ret < 0)
+ if (ret)
goto err;
return ret;
err:
- mfd_remove_devices(sec_pmic->dev);
sec_irq_exit(sec_pmic);
i2c_unregister_device(sec_pmic->rtc);
return ret;
--
1.8.1.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers: mfd: sec-core: Remove explicit call to mfd_remove_devices
2013-05-15 15:00 [PATCH] drivers: mfd: sec-core: Remove explicit call to mfd_remove_devices Leon Romanovsky
@ 2013-05-16 22:13 ` Samuel Ortiz
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Ortiz @ 2013-05-16 22:13 UTC (permalink / raw)
To: Leon Romanovsky; +Cc: sbkim73, linux-kernel
Hi Leon,
On Wed, May 15, 2013 at 06:00:48PM +0300, Leon Romanovsky wrote:
> In case mfd_add_devices will fail, it will call to mfd_remove_devices
> by itself and return non-zero value.
>
> Signed-off-by: Leon Romanovsky <leon@leon.nu>
> ---
> drivers/mfd/sec-core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied to mfd-next, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-16 22:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-15 15:00 [PATCH] drivers: mfd: sec-core: Remove explicit call to mfd_remove_devices Leon Romanovsky
2013-05-16 22:13 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox