* [PATCH 1/3] drivers/char/hw_random: remove leftover release_mem_region
@ 2013-05-22 13:21 Wolfram Sang
2013-05-22 13:21 ` [PATCH 2/3] drivers/usb/host: " Wolfram Sang
2013-05-22 13:21 ` [PATCH 3/3] sound/soc/fsl: " Wolfram Sang
0 siblings, 2 replies; 7+ messages in thread
From: Wolfram Sang @ 2013-05-22 13:21 UTC (permalink / raw)
To: linux-kernel; +Cc: Wolfram Sang, Deepak Saxena, Matt Mackall, Herbert Xu
When converting this driver to devm_ioremap_resource, the removal of this now
unneeded function has been forgotten.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/char/hw_random/omap-rng.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/char/hw_random/omap-rng.c b/drivers/char/hw_random/omap-rng.c
index d2903e7..7af2b24 100644
--- a/drivers/char/hw_random/omap-rng.c
+++ b/drivers/char/hw_random/omap-rng.c
@@ -52,7 +52,6 @@
*/
struct omap_rng_private_data {
void __iomem *base;
- struct resource *mem_res;
};
static inline u32 omap_rng_read_reg(struct omap_rng_private_data *priv, int reg)
@@ -107,6 +106,7 @@ static struct hwrng omap_rng_ops = {
static int omap_rng_probe(struct platform_device *pdev)
{
struct omap_rng_private_data *priv;
+ struct resource *mem_res;
int ret;
priv = kzalloc(sizeof(struct omap_rng_private_data), GFP_KERNEL);
@@ -118,8 +118,8 @@ static int omap_rng_probe(struct platform_device *pdev)
omap_rng_ops.priv = (unsigned long)priv;
dev_set_drvdata(&pdev->dev, priv);
- priv->mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- priv->base = devm_ioremap_resource(&pdev->dev, priv->mem_res);
+ mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ priv->base = devm_ioremap_resource(&pdev->dev, mem_res);
if (IS_ERR(priv->base)) {
ret = PTR_ERR(priv->base);
goto err_ioremap;
@@ -160,8 +160,6 @@ static int __exit omap_rng_remove(struct platform_device *pdev)
pm_runtime_put_sync(&pdev->dev);
pm_runtime_disable(&pdev->dev);
- release_mem_region(priv->mem_res->start, resource_size(priv->mem_res));
-
kfree(priv);
return 0;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 2/3] drivers/usb/host: remove leftover release_mem_region
2013-05-22 13:21 [PATCH 1/3] drivers/char/hw_random: remove leftover release_mem_region Wolfram Sang
@ 2013-05-22 13:21 ` Wolfram Sang
2013-05-22 14:21 ` Alan Stern
2013-05-22 13:21 ` [PATCH 3/3] sound/soc/fsl: " Wolfram Sang
1 sibling, 1 reply; 7+ messages in thread
From: Wolfram Sang @ 2013-05-22 13:21 UTC (permalink / raw)
To: linux-kernel; +Cc: Wolfram Sang, Alan Stern, Greg Kroah-Hartman, linux-usb
When converting this driver to devm_ioremap_resource, the removal of this now
unneeded function has been forgotten.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/usb/host/ohci-nxp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c
index f303cb0..f1db7eb 100644
--- a/drivers/usb/host/ohci-nxp.c
+++ b/drivers/usb/host/ohci-nxp.c
@@ -351,7 +351,6 @@ static int usb_hcd_nxp_remove(struct platform_device *pdev)
usb_remove_hcd(hcd);
nxp_stop_hc();
- release_mem_region(hcd->rsrc_start, hcd->rsrc_len);
usb_put_hcd(hcd);
clk_disable(usb_pll_clk);
clk_put(usb_pll_clk);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/3] drivers/usb/host: remove leftover release_mem_region
2013-05-22 13:21 ` [PATCH 2/3] drivers/usb/host: " Wolfram Sang
@ 2013-05-22 14:21 ` Alan Stern
0 siblings, 0 replies; 7+ messages in thread
From: Alan Stern @ 2013-05-22 14:21 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-kernel, Greg Kroah-Hartman, linux-usb
On Wed, 22 May 2013, Wolfram Sang wrote:
> When converting this driver to devm_ioremap_resource, the removal of this now
> unneeded function has been forgotten.
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
> drivers/usb/host/ohci-nxp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c
> index f303cb0..f1db7eb 100644
> --- a/drivers/usb/host/ohci-nxp.c
> +++ b/drivers/usb/host/ohci-nxp.c
> @@ -351,7 +351,6 @@ static int usb_hcd_nxp_remove(struct platform_device *pdev)
>
> usb_remove_hcd(hcd);
> nxp_stop_hc();
> - release_mem_region(hcd->rsrc_start, hcd->rsrc_len);
> usb_put_hcd(hcd);
> clk_disable(usb_pll_clk);
> clk_put(usb_pll_clk);
Acked-by: Alan Stern <stern@rowland.harvard.edu>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 3/3] sound/soc/fsl: remove leftover release_mem_region
2013-05-22 13:21 [PATCH 1/3] drivers/char/hw_random: remove leftover release_mem_region Wolfram Sang
2013-05-22 13:21 ` [PATCH 2/3] drivers/usb/host: " Wolfram Sang
@ 2013-05-22 13:21 ` Wolfram Sang
2013-05-22 15:56 ` Mark Brown
1 sibling, 1 reply; 7+ messages in thread
From: Wolfram Sang @ 2013-05-22 13:21 UTC (permalink / raw)
To: linux-kernel
Cc: Wolfram Sang, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, alsa-devel
When converting this driver to devm_ioremap_resource, the removal of this now
unneeded function has been forgotten.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
sound/soc/fsl/imx-ssi.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/sound/soc/fsl/imx-ssi.c b/sound/soc/fsl/imx-ssi.c
index c6fa03e..404314d 100644
--- a/sound/soc/fsl/imx-ssi.c
+++ b/sound/soc/fsl/imx-ssi.c
@@ -627,7 +627,6 @@ failed_pdev_fiq_add:
failed_pdev_fiq_alloc:
snd_soc_unregister_component(&pdev->dev);
failed_register:
- release_mem_region(res->start, resource_size(res));
clk_disable_unprepare(ssi->clk);
failed_clk:
@@ -636,7 +635,6 @@ failed_clk:
static int imx_ssi_remove(struct platform_device *pdev)
{
- struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
struct imx_ssi *ssi = platform_get_drvdata(pdev);
platform_device_unregister(ssi->soc_platform_pdev);
@@ -647,7 +645,6 @@ static int imx_ssi_remove(struct platform_device *pdev)
if (ssi->flags & IMX_SSI_USE_AC97)
ac97_ssi = NULL;
- release_mem_region(res->start, resource_size(res));
clk_disable_unprepare(ssi->clk);
return 0;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 3/3] sound/soc/fsl: remove leftover release_mem_region
2013-05-22 13:21 ` [PATCH 3/3] sound/soc/fsl: " Wolfram Sang
@ 2013-05-22 15:56 ` Mark Brown
2013-05-22 16:04 ` Wolfram Sang
0 siblings, 1 reply; 7+ messages in thread
From: Mark Brown @ 2013-05-22 15:56 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
alsa-devel
[-- Attachment #1: Type: text/plain, Size: 281 bytes --]
On Wed, May 22, 2013 at 03:21:26PM +0200, Wolfram Sang wrote:
> When converting this driver to devm_ioremap_resource, the removal of this now
> unneeded function has been forgotten.
This doesn't apply against current code, can you please regenerate
against topic/fsl or mainline?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 3/3] sound/soc/fsl: remove leftover release_mem_region
2013-05-22 15:56 ` Mark Brown
@ 2013-05-22 16:04 ` Wolfram Sang
2013-05-22 16:40 ` Mark Brown
0 siblings, 1 reply; 7+ messages in thread
From: Wolfram Sang @ 2013-05-22 16:04 UTC (permalink / raw)
To: Mark Brown
Cc: linux-kernel, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
alsa-devel
On Wed, May 22, 2013 at 10:56:28AM -0500, Mark Brown wrote:
> On Wed, May 22, 2013 at 03:21:26PM +0200, Wolfram Sang wrote:
> > When converting this driver to devm_ioremap_resource, the removal of this now
> > unneeded function has been forgotten.
>
> This doesn't apply against current code, can you please regenerate
> against topic/fsl or mainline?
? Works fine against v3.10-rc2 here. Or is mainline v3.9 for you?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 3/3] sound/soc/fsl: remove leftover release_mem_region
2013-05-22 16:04 ` Wolfram Sang
@ 2013-05-22 16:40 ` Mark Brown
0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2013-05-22 16:40 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
alsa-devel
[-- Attachment #1: Type: text/plain, Size: 437 bytes --]
On Wed, May 22, 2013 at 06:04:00PM +0200, Wolfram Sang wrote:
> On Wed, May 22, 2013 at 10:56:28AM -0500, Mark Brown wrote:
> > This doesn't apply against current code, can you please regenerate
> > against topic/fsl or mainline?
> ? Works fine against v3.10-rc2 here. Or is mainline v3.9 for you?
To be honest I didn't actually try mainline as I wasn't expecting any
conflicts from the branch and it didn't seem urgent as a bug fix.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-05-22 16:41 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-22 13:21 [PATCH 1/3] drivers/char/hw_random: remove leftover release_mem_region Wolfram Sang
2013-05-22 13:21 ` [PATCH 2/3] drivers/usb/host: " Wolfram Sang
2013-05-22 14:21 ` Alan Stern
2013-05-22 13:21 ` [PATCH 3/3] sound/soc/fsl: " Wolfram Sang
2013-05-22 15:56 ` Mark Brown
2013-05-22 16:04 ` Wolfram Sang
2013-05-22 16:40 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox