From: Samuel Ortiz <sameo@linux.intel.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-kernel@vger.kernel.org, lee.jones@linaro.org,
Miguel Aguilar <miguel.aguilar@ridgerun.com>
Subject: Re: [PATCH Resend 1/1] mfd: davinci_voicecodec: Convert to use devm_* APIs
Date: Tue, 18 Jun 2013 10:40:17 +0200 [thread overview]
Message-ID: <20130618084017.GA7161@zurbaran> (raw)
In-Reply-To: <1371025182-31386-1-git-send-email-sachin.kamat@linaro.org>
Hi Sachin,
On Wed, Jun 12, 2013 at 01:49:42PM +0530, Sachin Kamat wrote:
> devm_* APIs are device managed and make code simpler.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Miguel Aguilar <miguel.aguilar@ridgerun.com>
> ---
> CC'd Lee Jones
>
> Patch is based on mfd-next tree and compile tested.
> This driver gives following compilation error (not introduced by this patch):
> drivers/mfd/davinci_voicecodec.c:86:3: error: implicit declaration
> of function ‘io_v2p’ [-Werror=implicit-function-declaration]
> (dma_addr_t)(io_v2p(davinci_vc->base) + DAVINCI_VC_WFIFO);
>
> In order to test my changes I added the following to davinci_voicecodec.h file:
> +#define IO_OFFSET 0xfd000000 /* Virtual IO = 0xfec00000 */
> +#define io_v2p(va) ((va) - IO_OFFSET)
>
> I am not sure if these changes are right fix for the above error.
io_v2p is define in davinci's mach/hardware.h so I believe this is what
you should include in davinci_voicecodec.h.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2013-06-18 8:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 8:19 [PATCH Resend 1/1] mfd: davinci_voicecodec: Convert to use devm_* APIs Sachin Kamat
2013-06-13 10:49 ` Lee Jones
2013-06-14 4:20 ` Sachin Kamat
2013-06-14 7:06 ` Lee Jones
2013-06-14 8:18 ` Sachin Kamat
2013-06-18 8:40 ` Samuel Ortiz [this message]
2013-06-18 8:43 ` Sachin Kamat
2013-06-18 9:17 ` Samuel Ortiz
2013-06-18 9:23 ` Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618084017.GA7161@zurbaran \
--to=sameo@linux.intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.aguilar@ridgerun.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox