Re: [PATCH Resend 1/1] mfd: davinci_voicecodec: Convert to use devm_* APIs

[Samuel Ortiz <sameo@linux.intel.com>]

On Tue, Jun 18, 2013 at 02:13:48PM +0530, Sachin Kamat wrote:
> Hi Samuel,
> 
> On 18 June 2013 14:10, Samuel Ortiz <sameo@linux.intel.com> wrote:
> > Hi Sachin,
> >
> > On Wed, Jun 12, 2013 at 01:49:42PM +0530, Sachin Kamat wrote:
> >> devm_* APIs are device managed and make code simpler.
> >>
> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> >> Cc: Miguel Aguilar <miguel.aguilar@ridgerun.com>
> >> ---
> >> CC'd Lee Jones
> >>
> >> Patch is based on mfd-next tree and compile tested.
> >> This driver gives following compilation error (not introduced by this patch):
> >> drivers/mfd/davinci_voicecodec.c:86:3: error: implicit declaration
> >> of function ‘io_v2p’ [-Werror=implicit-function-declaration]
> >>    (dma_addr_t)(io_v2p(davinci_vc->base) + DAVINCI_VC_WFIFO);
> >>
> >> In order to test my changes I added the following to davinci_voicecodec.h file:
> >> +#define IO_OFFSET      0xfd000000 /* Virtual IO = 0xfec00000 */
> >> +#define io_v2p(va)     ((va) - IO_OFFSET)
> >>
> >> I am not sure if these changes are right fix for the above error.
> > io_v2p is define in davinci's mach/hardware.h so I believe this is what
> > you should include in davinci_voicecodec.h.
> 
> Thanks. That was only required for compile testing my patch.
> Does the patch look good?
Yes, but I'd appreciate if you could also fix the driver build failures
as well.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/