From: Paul Clements <paul.clements@steeleye.com>
To: <akpm@linux-foundation.org>
Cc: <linux-kernel@vger.kernel.org>, <paul.clements@steeleye.com>,
<belczyk@bsd.krakow.pl>
Subject: [PATCH] nbd: remove bogus BUG_ON in NBD_CLEAR_QUE
Date: Tue, 18 Jun 2013 17:03:46 -0400 (EDT) [thread overview]
Message-ID: <20130618210346.659F0222D8@clements> (raw)
From: Michal Belczyk <belczyk@bsd.krakow.pl>
The NBD_CLEAR_QUE ioctl has been deprecated for quite some time (its job
is now done by two other ioctls). We should stop trying to make bogus
assertions in it. Also, user-level code should remove calls to
NBD_CLEAR_QUE, ASAP.
Signed-off-by: Michal Belczyk <belczyk@bsd.krakow.pl>
Signed-off-by: Paul Clements <paul.clements@steeleye.com>
---
nbd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 7fecc78..21ba264 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -750,7 +750,6 @@ static int __nbd_ioctl(struct block_device *bdev, struct nbd_device *nbd,
* This is for compatibility only. The queue is always cleared
* by NBD_DO_IT or NBD_CLEAR_SOCK.
*/
- BUG_ON(!nbd->sock && !list_empty(&nbd->queue_head));
return 0;
case NBD_PRINT_DEBUG:
reply other threads:[~2013-06-18 21:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618210346.659F0222D8@clements \
--to=paul.clements@steeleye.com \
--cc=akpm@linux-foundation.org \
--cc=belczyk@bsd.krakow.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox