* [PATCH] nbd: remove bogus BUG_ON in NBD_CLEAR_QUE
@ 2013-06-18 21:03 Paul Clements
0 siblings, 0 replies; only message in thread
From: Paul Clements @ 2013-06-18 21:03 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, paul.clements, belczyk
From: Michal Belczyk <belczyk@bsd.krakow.pl>
The NBD_CLEAR_QUE ioctl has been deprecated for quite some time (its job
is now done by two other ioctls). We should stop trying to make bogus
assertions in it. Also, user-level code should remove calls to
NBD_CLEAR_QUE, ASAP.
Signed-off-by: Michal Belczyk <belczyk@bsd.krakow.pl>
Signed-off-by: Paul Clements <paul.clements@steeleye.com>
---
nbd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 7fecc78..21ba264 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -750,7 +750,6 @@ static int __nbd_ioctl(struct block_device *bdev, struct nbd_device *nbd,
* This is for compatibility only. The queue is always cleared
* by NBD_DO_IT or NBD_CLEAR_SOCK.
*/
- BUG_ON(!nbd->sock && !list_empty(&nbd->queue_head));
return 0;
case NBD_PRINT_DEBUG:
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-06-18 21:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-18 21:03 [PATCH] nbd: remove bogus BUG_ON in NBD_CLEAR_QUE Paul Clements
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox