* [patch] lib/scatterlist: error handling in __sg_alloc_table()
@ 2013-06-20 8:12 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2013-06-20 8:12 UTC (permalink / raw)
To: Andrew Morton
Cc: Imre Deak, Daniel Vetter, Maxim Levitsky, Tejun Heo, linux-kernel
I was reviewing code which I suspected might allocate a zero size SG
table. That will cause memory corruption. Also we can't return before
doing the memset or we could end up using uninitialized memory in the
cleanup path.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/lib/scatterlist.c b/lib/scatterlist.c
index a1cf8ca..d39178b 100644
--- a/lib/scatterlist.c
+++ b/lib/scatterlist.c
@@ -247,13 +247,15 @@ int __sg_alloc_table(struct sg_table *table, unsigned int nents,
struct scatterlist *sg, *prv;
unsigned int left;
+ memset(table, 0, sizeof(*table));
+
+ if (nents == 0)
+ return -EINVAL;
#ifndef ARCH_HAS_SG_CHAIN
if (WARN_ON_ONCE(nents > max_ents))
return -EINVAL;
#endif
- memset(table, 0, sizeof(*table));
-
left = nents;
prv = NULL;
do {
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-06-20 8:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-20 8:12 [patch] lib/scatterlist: error handling in __sg_alloc_table() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox