[patch v1 1/1]mfd: fix for DA9055 driver initialization

[patch v1 1/1]mfd: fix for DA9055 driver initialization

[Ankur Raina]

[-- Attachment #1: Type: text/plain, Size: 1022 bytes --]

This patch adds support for clearing events received while
powering up DA9055.

Signed-off-by: Ankur <Ankur.Raina@kpitcummins.com>
---
 drivers/mfd/da9055-core.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/drivers/mfd/da9055-core.c b/drivers/mfd/da9055-core.c
index 49cb23d..e4c0596 100644
--- a/drivers/mfd/da9055-core.c
+++ b/drivers/mfd/da9055-core.c
@@ -381,6 +381,7 @@ int da9055_device_init(struct da9055 *da9055)
 {
 	struct da9055_pdata *pdata = da9055->dev->platform_data;
 	int ret;
+	uint8_t clear_events[3] = {0xFF, 0xFF, 0xFF};
 
 	if (pdata && pdata->init != NULL)
 		pdata->init(da9055);
@@ -390,6 +391,10 @@ int da9055_device_init(struct da9055 *da9055)
 	else
 		da9055->irq_base = pdata->irq_base;
 
+	ret = da9055_group_write(da9055, DA9055_REG_EVENT_A, 3, clear_events);
+	if (ret < 0)
+		return ret;
+
 	ret = regmap_add_irq_chip(da9055->regmap, da9055->chip_irq,
 				  IRQF_TRIGGER_LOW | IRQF_ONESHOT,
 				  da9055->irq_base, &da9055_regmap_irq_chip,
-- 
1.7.1





[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 3588 bytes --]

Re: [patch v1 1/1]mfd: fix for DA9055 driver initialization

[Samuel Ortiz]

Hi Ankur,

On Thu, Jun 27, 2013 at 02:06:45PM +0000, Ankur Raina wrote:
> This patch adds support for clearing events received while
> powering up DA9055.
Could you please explain what that fixes ?

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

Re: [patch v1 1/1]mfd: fix for DA9055 driver initialization

[Ankur Raina]

On Thu, 2013-06-27 at 19:41 +0200, Samuel Ortiz wrote:
> Hi Ankur,
> 
> On Thu, Jun 27, 2013 at 02:06:45PM +0000, Ankur Raina wrote:
> > This patch adds support for clearing events received while
> > powering up DA9055.
> Could you please explain what that fixes ?
While powering up DA9055,events are received of power sequencer.Events are also received on gpio's.
These events remain uncleared after boot up, due to which further event handling also fails.
This patch clears all the events received, during driver initialization, so that we have a clean state after boot up.

> 
> Cheers,
> Samuel.
> 

Re: [patch v1 1/1]mfd: fix for DA9055 driver initialization

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 528 bytes --]

On Fri, Jun 28, 2013 at 04:18:39PM +0530, Ankur Raina wrote:

> > Could you please explain what that fixes ?

> While powering up DA9055,events are received of power sequencer.Events are also received on gpio's.
> These events remain uncleared after boot up, due to which further event handling also fails.
> This patch clears all the events received, during driver initialization, so that we have a clean state after boot up.

You need to explain this clearly in the patch description in a way that
can be related to the code.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]