From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: linux-arm-kernel@lists.infradead.org, giometti@enneenne.com,
Bo Shen <voice.shen@atmel.com>,
Ludovic Desroches <ludovic.desroches@atmel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: at91/DT: at91sam9x5ek: fix USB host property to enable port C
Date: Wed, 3 Jul 2013 13:01:37 +0200 [thread overview]
Message-ID: <20130703110137.GE21034@game.jcrosoft.org> (raw)
In-Reply-To: <1372849250-14715-1-git-send-email-nicolas.ferre@atmel.com>
On 13:00 Wed 03 Jul , Nicolas Ferre wrote:
> Device Tree "num-ports" property of USB host node has to be
> set to maximum number of ports available.
> The possibility to activate a particular port is done by specifying the proper
> gpio configuration for its vbus.
>
> This patch fixes the USB host node by configuring the 3 ports available on the
> product and letting "port A" available for USB gadget usage.
>
> Reported-by: Rodolfo Giometti <giometti@enneenne.com>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> Cc: Bo Shen <voice.shen@atmel.com>
Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
> arch/arm/boot/dts/at91sam9x5ek.dtsi | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91sam9x5ek.dtsi b/arch/arm/boot/dts/at91sam9x5ek.dtsi
> index b753855..49e3c45 100644
> --- a/arch/arm/boot/dts/at91sam9x5ek.dtsi
> +++ b/arch/arm/boot/dts/at91sam9x5ek.dtsi
> @@ -94,8 +94,9 @@
>
> usb0: ohci@00600000 {
> status = "okay";
> - num-ports = <2>;
> - atmel,vbus-gpio = <&pioD 19 GPIO_ACTIVE_LOW
> + num-ports = <3>;
> + atmel,vbus-gpio = <0 /* &pioD 18 GPIO_ACTIVE_LOW *//* Activate to have access to port A */
on 2 line would have been more clear
Best Regards,
J.
> + &pioD 19 GPIO_ACTIVE_LOW
> &pioD 20 GPIO_ACTIVE_LOW
> >;
> };
> --
> 1.8.2.2
>
prev parent reply other threads:[~2013-07-03 11:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 11:00 [PATCH] ARM: at91/DT: at91sam9x5ek: fix USB host property to enable port C Nicolas Ferre
2013-07-03 11:01 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130703110137.GE21034@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=giometti@enneenne.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=nicolas.ferre@atmel.com \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox