public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: at91/DT: at91sam9x5ek: fix USB host property to enable port C
@ 2013-07-03 11:00 Nicolas Ferre
  2013-07-03 11:01 ` Jean-Christophe PLAGNIOL-VILLARD
  0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Ferre @ 2013-07-03 11:00 UTC (permalink / raw)
  To: Jean-Christophe PLAGNIOL-VILLARD, linux-arm-kernel
  Cc: giometti, Bo Shen, Ludovic Desroches, linux-kernel, Nicolas Ferre

Device Tree "num-ports" property of USB host node has to be
set to maximum number of ports available.
The possibility to activate a particular port is done by specifying the proper
gpio configuration for its vbus.

This patch fixes the USB host node by configuring the 3 ports available on the
product and letting "port A" available for USB gadget usage.

Reported-by: Rodolfo Giometti <giometti@enneenne.com>
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Bo Shen <voice.shen@atmel.com>
---
 arch/arm/boot/dts/at91sam9x5ek.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/at91sam9x5ek.dtsi b/arch/arm/boot/dts/at91sam9x5ek.dtsi
index b753855..49e3c45 100644
--- a/arch/arm/boot/dts/at91sam9x5ek.dtsi
+++ b/arch/arm/boot/dts/at91sam9x5ek.dtsi
@@ -94,8 +94,9 @@
 
 		usb0: ohci@00600000 {
 			status = "okay";
-			num-ports = <2>;
-			atmel,vbus-gpio = <&pioD 19 GPIO_ACTIVE_LOW
+			num-ports = <3>;
+			atmel,vbus-gpio = <0 /* &pioD 18 GPIO_ACTIVE_LOW *//* Activate to have access to port A */
+					   &pioD 19 GPIO_ACTIVE_LOW
 					   &pioD 20 GPIO_ACTIVE_LOW
 					  >;
 		};
-- 
1.8.2.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: at91/DT: at91sam9x5ek: fix USB host property to enable port C
  2013-07-03 11:00 [PATCH] ARM: at91/DT: at91sam9x5ek: fix USB host property to enable port C Nicolas Ferre
@ 2013-07-03 11:01 ` Jean-Christophe PLAGNIOL-VILLARD
  0 siblings, 0 replies; 2+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2013-07-03 11:01 UTC (permalink / raw)
  To: Nicolas Ferre
  Cc: linux-arm-kernel, giometti, Bo Shen, Ludovic Desroches,
	linux-kernel

On 13:00 Wed 03 Jul     , Nicolas Ferre wrote:
> Device Tree "num-ports" property of USB host node has to be
> set to maximum number of ports available.
> The possibility to activate a particular port is done by specifying the proper
> gpio configuration for its vbus.
> 
> This patch fixes the USB host node by configuring the 3 ports available on the
> product and letting "port A" available for USB gadget usage.
> 
> Reported-by: Rodolfo Giometti <giometti@enneenne.com>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> Cc: Bo Shen <voice.shen@atmel.com>
Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>

> ---
>  arch/arm/boot/dts/at91sam9x5ek.dtsi | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91sam9x5ek.dtsi b/arch/arm/boot/dts/at91sam9x5ek.dtsi
> index b753855..49e3c45 100644
> --- a/arch/arm/boot/dts/at91sam9x5ek.dtsi
> +++ b/arch/arm/boot/dts/at91sam9x5ek.dtsi
> @@ -94,8 +94,9 @@
>  
>  		usb0: ohci@00600000 {
>  			status = "okay";
> -			num-ports = <2>;
> -			atmel,vbus-gpio = <&pioD 19 GPIO_ACTIVE_LOW
> +			num-ports = <3>;
> +			atmel,vbus-gpio = <0 /* &pioD 18 GPIO_ACTIVE_LOW *//* Activate to have access to port A */
on 2 line would have been more clear


Best Regards,
J.
> +					   &pioD 19 GPIO_ACTIVE_LOW
>  					   &pioD 20 GPIO_ACTIVE_LOW
>  					  >;
>  		};
> -- 
> 1.8.2.2
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-07-03 11:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-03 11:00 [PATCH] ARM: at91/DT: at91sam9x5ek: fix USB host property to enable port C Nicolas Ferre
2013-07-03 11:01 ` Jean-Christophe PLAGNIOL-VILLARD

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox