* [PATCH] mfd: stmpe: Staticise stmpe_of_probe()
@ 2013-07-28 14:03 Mark Brown
2013-07-31 10:54 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2013-07-28 14:03 UTC (permalink / raw)
To: Samuel Ortiz, Lee Jones; +Cc: linux-kernel, Mark Brown
From: Mark Brown <broonie@linaro.org>
It is only called from this file so there is no need for it to be in the
global namespace and cause sparse to warn.
Signed-off-by: Mark Brown <broonie@linaro.org>
---
drivers/mfd/stmpe.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
index 5d5e6f9..fff63a4 100644
--- a/drivers/mfd/stmpe.c
+++ b/drivers/mfd/stmpe.c
@@ -1106,7 +1106,8 @@ static int stmpe_devices_init(struct stmpe *stmpe)
return ret;
}
-void stmpe_of_probe(struct stmpe_platform_data *pdata, struct device_node *np)
+static void stmpe_of_probe(struct stmpe_platform_data *pdata,
+ struct device_node *np)
{
struct device_node *child;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mfd: stmpe: Staticise stmpe_of_probe()
2013-07-28 14:03 [PATCH] mfd: stmpe: Staticise stmpe_of_probe() Mark Brown
@ 2013-07-31 10:54 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2013-07-31 10:54 UTC (permalink / raw)
To: Mark Brown; +Cc: Samuel Ortiz, linux-kernel, Mark Brown
On Sun, 28 Jul 2013, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> It is only called from this file so there is no need for it to be in the
> global namespace and cause sparse to warn.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
> drivers/mfd/stmpe.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
Applied, thanks.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-31 10:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-28 14:03 [PATCH] mfd: stmpe: Staticise stmpe_of_probe() Mark Brown
2013-07-31 10:54 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox